Fix isothermal domain test connections#478
Merged
ChrisRackauckas merged 1 commit intoJul 13, 2026
Merged
Conversation
This was referenced Jul 13, 2026
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
agent/fix-isothermal-dynamic-volume-balance
branch
from
July 13, 2026 09:32
7b7966a to
1cb8337
Compare
Member
Author
|
Rebase and validation update:
The official integration Core run now reaches and passes Isothermal 27/27, then exposes only the separately audited magnetic one-ULP assertion. |
Member
Author
|
Post-rebase native
The group then stopped at |
ChrisRackauckas
marked this pull request as ready for review
July 13, 2026 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
domain_connectfor hydraulic domain propagation instead of routing flow equations through the fluid parameter setter.ModelingToolkitBase.bindingsAPI.Root cause
ModelingToolkit commit
b0f315369stopped silently zeroing underconstrained variables during alias elimination. The immediate parent80f7f62bcpasses the reduced DynamicVolume model, whileb0f315369reports 48 highest-order variables and 47 equations. The tests were using a fluid domain setter as a physical flow connector, which hid the model structure behind the removed zeroing behavior.The Actuator test also copied a failed zero-length solution by zipping
unknowns(initsys)with rawinitsol.ustorage. Its public problem operating point containspiston.dx = 0, while the copied raw value wasNaN. Reading each unknown throughinitprob[v]preserves the intended operating point.Validation
1cb83378on currentmain8539d8f2(merged test: use Base.ifelse in Chua circuit #477).test/isothermal_compressible.jlon Julia 1.12.6, exit 0:80f7f62bc: exit 0b0f315369: exit 1, 48 variables / 47 equationsGROUP=Core Pkg.test()on a temporary validation stack containing current main, this patch, and Fix callable interpolation builder symtype #480: Analog 100/100, Chua 1/1, Continuous 76/76, Digital 34/34, and Isothermal 27/27; the run then stopped on the separate clean-main exact-equality assertion intest/magnetic.jl:66, which is under an independent reproduction and ULP analysis.--check .: exit 0 across 81 files.git diff --check: exit 0.No test was skipped, disabled, silenced, or made warn-only.
Related: #457, merged #477, and #480.