test: use Base.ifelse in Chua circuit#477
Merged
ChrisRackauckas merged 1 commit intoJul 13, 2026
Merged
Conversation
Member
Author
|
Execution note for commit
The later isothermal errors noted in the PR body are kept separate from this focused regression fix. |
Member
Author
|
CI triage update:
These residual failures are disclosed rather than folded into this one-line Chua fix. |
This was referenced Jul 12, 2026
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
agent/fix-chua-base-ifelse
branch
from
July 13, 2026 02:37
37ce6f4 to
48dfbc6
Compare
Member
Author
|
Base-freshness update:
The broader Core run is continuing through the remaining files; its exact commit set also includes the separately reviewed #478 test repair and the focused ParametrizedInterpolation source fix, and will be reported separately rather than attributed solely to this PR. |
This was referenced Jul 13, 2026
ChrisRackauckas
marked this pull request as ready for review
July 13, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the stale
using IfElse: ifelsefrom the Chua circuit test. The test now uses Julia's built-inBase.ifelse, matching the production-code migration in #473.Root cause
Commit
dca3a237b1cda8c6befdf5bd0ef53f4c03fbd9b9removed IfElse.jl from the package dependencies and migrated production call sites, but missedtest/chua_circuit.jl. The Core group has therefore failed at test loading since #473; the first bad release is v2.29.3 (v2.29.2 is the last release before the removal), and v2.29.4 remains affected.This also breaks ModelingToolkit's downstream Core job on both master and unrelated PRs:
Verification
Using Julia 1.12.6, ModelingToolkit
ee7dd34d8b7cfe8a085e0fa04cec28a607053f66, and the reusable downstream workflow locally:Runic v1.7.0 --check .also completed successfully.The full Core run continued past Chua and exposed three unrelated
isothermal_compressible.jlExtraVariablesSystemExceptionerrors. Those are outside this one-line test-import fix and are being routed to a separate clean-main reproduction/bisect; they were previously masked by the earlier Chua load error.Please ignore this PR until reviewed by @ChrisRackauckas.