Raise SymbolicUtils floor for minimum dependency tests#479
Merged
ChrisRackauckas merged 1 commit intoJul 12, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 12, 2026 23:53
Member
Author
|
CI checkpoint:
No assertion was loosened or skipped. The HeatingDiode successful-retcode regression and existing strict current bound both pass. |
Member
Author
|
Post-merge downstream CI classification:
This failure occurs after the SymbolicUtils-floor change's relevant MTK groups passed and is not caused by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
Root cause
The minimum-dependency workflow started selecting SymbolicUtils 4.10.0 after SymbolicUtils became a direct dependency. With the workflow's ModelingToolkit 11.2.0 / OrdinaryDiffEq 6.103.0 stack, SymbolicUtils 4.10.0 leaves a
-3.48e-14algebraic residual at the reverse-current bound. The computed minimum current is consequently-1.0000000347787363e-6, just below the model's existing physical assertion of-1e-6.The same diagnostic stack produces exactly
-1e-6with SymbolicUtils 4.38.1 and 4.40.0. Tightening the solver tolerances did not remove the sign-sensitive residual with 4.10.0, so this keeps the test assertion unchanged and raises the dependency floor to the first verified good release instead.Validation
Runic 1.7.0 --check Project.toml test/analog.jl: passedCore/analog.jl | 100 pass, 100 totalIfElsetest-dependency error inCore/chua_circuit.jl; that blocker is already addressed by draft PR test: use Base.ifelse in Chua circuit #477Failing CI reproduced from https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/runs/29193734380/job/86652873871.