test: exercise SISO initialization through ODEProblem#491
test: exercise SISO initialization through ODEProblem#491ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
|
Investigation scratchpad for commit
The clean-main full Core run's earlier translational error is independently handled by #489; this commit deliberately does not duplicate that fix. |
|
CI classification: the Julia LTS Core failure is the independently audited clean-main translational regression, not this SISO change.
The SISO test was therefore not reached by this job. Its exact Julia 1.10.11 dependency set passed the complete |
8bfa82b to
4c909e3
Compare
|
Stack update: #491 now contains exact #489 commit Before the history rewrite I fetched both remote branches and verified:
I rebased only #491 and force-pushed it with an explicit lease against the verified old #491 hash. The #489 branch was not modified. Please merge #489 first; afterward this PR's effective diff collapses to Post-stack local verification on Julia 1.10.11/current-LTS dependencies:
|
|
Independent audit adds two narrower boundary checks that complement the existing investigation:
No additional code change is suggested by this comment. |
|
Replacement stacked CI confirms that the Julia LTS Core suite passes end to end:
This verifies the #489 translational fix and this PR's SISO fix together on Julia LTS. PR #491 remains stacked on the exact #489 head commit so the two circular CI failures can be reviewed and merged in order. |
|
The stacked Downgrade Tests job also passes end to end:
This is the dependency lane that previously exposed the lost |
|
Combined-stack CI update: Core passes with both commits present on Julia LTS, current, and prerelease. QA, downgrade, documentation, Runic, and spelling also pass. The only remaining active check is ModelingToolkit downstream. An independent fresh-depot Julia 1.12 GROUP=Core run of this exact two-commit head is still running locally; I will post its native summary separately rather than treating CI as local verification. |
|
Independent local combined-stack validation on exact head 4c909e3: the native GROUP=Core Pkg.test run under Julia 1.12 completed with exit 0 and the final ModelingToolkitStandardLibrary tests-passed message. The target files passed Core/translational.jl 16/16 and Core/utils.jl 14/14 in the same full Core process. Whole-checkout Runic then exited 0 and git diff --check exited 0. Transparency note: an initial Runic-dot invocation traversed the untracked .depot package cache and hit Runic parser assertions in MLStyle/SymbolicUtils dependency test files; moving that temporary cache outside the checkout produced the repository-only exit-0 result above. |
The standalone initialization problem represents an intermediate system, so it can lose defaults or observed variables from the original ODE system. Construct the ODE problem and assert the same initialized values through its public indexing API. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
4c909e3 to
8b15650
Compare
|
Current-main rebase and exact downgrade replay:
The PR body now reflects the unstacked current-main state and these fresh controls. |
|
Post-hold terminal CI classification for current head
The exact local minimum graph remains decisive for this one-test change: clean base reports 587 pass / 3 existing broken / 1 SISO error, while I am therefore classifying the lone cancellation as the downstream |
Please ignore this PR until reviewed by @ChrisRackauckas.
Summary
ODEProbleminstead of solving the standaloneInitializationProblem.1.0.ODEProblemfrom its declaring public module,SciMLBase, and remove the now-unusedOrdinaryDiffEqimport.This is a focused extraction of the SISO change from draft PR #452. That PR contains unrelated changes and conflicts; none of those changes are included here. The branch is now rebased on current
mainafter #489 merged, so this PR contains one commit and changes onlytest/utils.jl.Root cause
PR #469 replaced the old manual
generate_initializesystem/NonlinearProblempath withInitializationProblem. A standalone initialization problem is keyed to its intermediate initialization system, not the fully initialized original ODE system. This has two resolver-dependent failure modes:initsol[sys.so.xd]is0.0, not the declared1.0initial value.sys.so.uhas been eliminated from the initialization system, so indexing it throwsArgumentError: Symbol so₊u(t) is not present in the system.ODEProblemperforms the complete operating-point / initialization preprocessing and retains the public indexing semantics for both original states and observed variables. The test still checks exactly the same two values; it now checks them on the object whose initialization behavior matters to users.A signature-specific source bisect identifies
3672b875(PR #469) as the first commit producing the missing-observed-symbol behavior; its parenta79a77f3passes this SISO check on the preserved graph.git log --followconfirms #469 is still the latestmainedit to this test.Exact current-main reproduction
The current-main downgrade run 29870067371, job 88767752470, fails at
test/utils.jl:41with the missing-so₊uerror: 13 pass / 1 error inCore/utils.jl.I replayed exact main
4459350cf3dc5db67ab330ed9f2f8965a3aae1afand this one-commit candidate from fresh isolated depots with Julia 1.10.11. Both used exact action commitfab1defb76df9fd672f63c94df73ce131d32e134, the workflow's strictdepsresolution, stdlib skip list, andMooncakeno-promote setting. All 171 installed package/version pairs match the hosted job, and the base/candidate manifests are byte-identical (SHA-256fb0b7750f5a20e677cc23eb4e6ff3d8686829c95ee61bced6b6dcc399df0dc29).GROUP=Coreexited 1 with 587 pass / 3 broken / 1 error across 19 files, reproducing the hostedso₊usignature.8b156503: the same officialGROUP=Coreinvocation exited 0 with 588 pass / 3 broken / 0 fail / 0 error, ending withTesting ModelingToolkitStandardLibrary tests passed.Core/translational.jl: 16/16 passed, confirming the merged Initialize translational acceleration sensor test #489 fix is included through the base rather than duplicated here.Core/utils.jl: 14/14 passed, including SISO 2/2 with both exact1.0assertions unchanged.--checkpassed for the repository root.git diff --checkpassed.Earlier focused validation also passed the complete
test/utils.jlon Julia 1.10.11 minimum/current graphs and Julia 1.12.6 current dependencies; the exact current-main full-harness replay above supersedes the former stacked-branch qualification.