Skip to content

Remove legacy developer preview concepts#8020

Open
isaacroldan wants to merge 1 commit into
remove-supports-dev-sessionsfrom
remove-legacy-dev-preview-concepts
Open

Remove legacy developer preview concepts#8020
isaacroldan wants to merge 1 commit into
remove-supports-dev-sessionsfrom
remove-legacy-dev-preview-concepts

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Remove the legacy developer preview UI/component and related GraphQL client surface.
  • Remove canEnablePreviewMode and developerPreviewController now that app dev always uses dev sessions.
  • Simplify updateURLsPrompt by removing the usingDevSessions branch.

Validation:

  • pnpm vitest run packages/app/src/cli/prompts/dev.test.ts packages/app/src/cli/services/dev/ui.test.tsx packages/app/src/cli/services/dev/urls.test.ts
  • pnpm --filter app type-check
  • pnpm --filter app lint
  • pnpm knip

isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@isaacroldan isaacroldan marked this pull request as ready for review July 7, 2026 10:35
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 7, 2026
@isaacroldan isaacroldan requested a review from a team as a code owner July 7, 2026 10:35
@isaacroldan isaacroldan force-pushed the remove-legacy-dev-preview-concepts branch 2 times, most recently from d313a88 to f98548c Compare July 7, 2026 13:31
@isaacroldan isaacroldan force-pushed the remove-supports-dev-sessions branch 2 times, most recently from 87d82ff to f381aa6 Compare July 8, 2026 09:35
@isaacroldan isaacroldan force-pushed the remove-legacy-dev-preview-concepts branch from f98548c to 93f86e3 Compare July 8, 2026 09:35
Assisted-By: devx/782ef931-ac0a-4cc4-bff1-a2511c379664
@isaacroldan isaacroldan force-pushed the remove-supports-dev-sessions branch from f381aa6 to 7d1f4f0 Compare July 8, 2026 09:58
@isaacroldan isaacroldan force-pushed the remove-legacy-dev-preview-concepts branch from 93f86e3 to 44cfd9a Compare July 8, 2026 09:58
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -6,7 +6,6 @@ export declare const environmentVariables: {
     doctor: string;
     enableCliRedirect: string;
     env: string;
-    firstPartyDev: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -63,13 +63,6 @@ export declare function alwaysLogAnalytics(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if SHOPIFY_CLI_ALWAYS_LOG_METRICS is truthy.
  */
 export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
-/**
- * Returns true if the CLI User is 1P.
- *
- * @param env - The environment variables from the environment of the current process.
- * @returns True if SHOPIFY_CLI_1P is truthy.
- */
-export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if the CLI can run the "doctor-release" command.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant