Include keywords in completion candidates#681
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
vinistock
force-pushed
the
03-19-include_keywords_in_completion_candidates
branch
from
39d3a9e to
3d8dedd
Compare
vinistock
force-pushed
the
03-19-add_keywords_to_model
branch
from
d2fea3b to
95a68ed
Compare
vinistock
force-pushed
the
03-19-include_keywords_in_completion_candidates
branch
from
3d8dedd to
f925fef
Compare
This was referenced Mar 20, 2026
alexcrocha
approved these changes
Mar 21, 2026
Contributor
alexcrocha
left a comment
alexcrocha
left a comment
There was a problem hiding this comment.
Note: there are certain scenarios where a keyword isn't valid. We don't currently try to filter those out.
Piqued my attention, curious about intent. Is this something we'd want to tackle in Rubydex later, or are we leaving it for the consumer to handle?
Member
Author
|
That's a good question. It might be better suited for the consumer to filter out which keywords don't apply since they have context of the surrounding code. I haven't really explored this in much detail, so I don't yet know if it would be feasible to filter it out on the Rubydex side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start including keywords as part of expression completion.
Note: there are certain scenarios where a keyword isn't valid. We don't currently try to filter those out.