Open
Conversation
This was referenced Mar 20, 2026
Merged
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8231f38 to
41aee58
Compare
41aee58 to
71c7e50
Compare
Morriar
reviewed
Mar 24, 2026
alexcrocha
reviewed
Mar 26, 2026
71c7e50 to
aa6ed89
Compare
aa6ed89 to
bcc8e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Easier reviewed by commit. This PR exposes completion to the Ruby API.
Relevant decisions
Method structure
I tried to have a unified API for completion, but it actually makes things quite confusing. Each completion scenario requires different inputs, so trying to merge everything makes for a very unintuitive API.
Also, C is not very elegant when handling optional data for an enum, so you end up with this weird implementation with a bunch of pointers that are only expected to not be null for certain scenarios. This is why I went with separate completion methods for each scenario.
Completion response
We could use the LSP structure as the response for completion. However, I think that ties us unnecessarily to the LSP protocol and there might be other useful cases for completion.
I went with trying to return as much data as possible for the entities:
kind