Open
Conversation
Author
|
https://github.com/SiaFoundation/coreutils/actions/runs/22319186629/job/64572476630?pr=401 These tests appear to be NDF? I can't get it to fail on my machine. |
ChrisSchinnerl
requested changes
Feb 24, 2026
| RenterSignature: revision.RenterSignature, | ||
| } | ||
|
|
||
| if err := req.Validate(); err != nil { |
Member
There was a problem hiding this comment.
This should be called in handleRPCFundAccounts. The server needs to perform the validation rather than the client.
Comment on lines
+5
to
+9
| # validate RPCFundAccountsRequest | ||
|
|
||
| #401 by @Alrighttt | ||
|
|
||
| This method was implemented but never used. |
Member
There was a problem hiding this comment.
Suggested change
| # validate RPCFundAccountsRequest | |
| #401 by @Alrighttt | |
| This method was implemented but never used. | |
| # Validate RPCFundAccountsRequest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was implemented but never used.