Skip to content

validate RPCFundAccountsRequest #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n8mgr merged 4 commits into from
Feb 25, 2026
+11 −0
Merged

validate RPCFundAccountsRequest #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48050f5
validate RPCFundAccountsRequest
Alrighttt Feb 23, 2026
9d31add
Auto generate changeset
knope-bot[bot] Feb 23, 2026
471b418
Update .changeset/validate_rpcfundaccountsrequest.md
Alrighttt Feb 25, 2026
1232cb2
add validate to handleRPCFundAccounts
ChrisSchinnerl Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/validate_rpcfundaccountsrequest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

# Validate RPCFundAccountsRequest
4 changes: 4 additions & 0 deletions rhp/v4/rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,10 @@ func RPCFundAccounts(ctx context.Context, t TransportClient, cs consensus.State,
RenterSignature: revision.RenterSignature,
}

if err := req.Validate(); err != nil {
return RPCFundAccountResult{}, fmt.Errorf("invalid request: %w", err)
}

var resp rhp4.RPCFundAccountsResponse
if err := callSingleRoundtripRPC(ctx, t, rhp4.RPCFundAccountsID, &req, &resp); err != nil {
return RPCFundAccountResult{}, err
Expand Down
2 changes: 2 additions & 0 deletions rhp/v4/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,8 @@ func (s *Server) handleRPCFundAccounts(stream net.Conn) error {
var req rhp4.RPCFundAccountsRequest
if err := rhp4.ReadRequest(stream, &req); err != nil {
return errorDecodingError("failed to read request: %v", err)
} else if err := req.Validate(); err != nil {
return err
}

state, unlock, err := s.lockContractForRevision(req.ContractID)
Expand Down