Add customizable tick marks and upgrade LibEQOL#72
Open
taijuten wants to merge 4 commits intoSnsei987:mainfrom
Open
Add customizable tick marks and upgrade LibEQOL#72taijuten wants to merge 4 commits intoSnsei987:mainfrom
taijuten wants to merge 4 commits intoSnsei987:mainfrom
Conversation
Features: - Added support for up to 4 custom tick marks per resource type - Each tick can be configured with: * Enable/disable toggle * Resource type selection (9 power types supported) * Mode: Percentage (0-100%) or Fixed value * Numeric value input with validation - All tick settings grouped under collapsible 'Tick Settings' section - Ticks are filtered by resource type and rendered based on mode - Locale strings added for all new settings Library Updates: - Upgraded LibEQOL from 1.0.0 to 15.0.0-beta-2 - Leverages new Input setting type with built-in numeric validation
taijuten
force-pushed
the
custom-tick-marks
branch
from
9d2fcfa to
ce79a82
Compare
Contributor
Author
|
Addresses #73 |
Snsei987
reviewed
Jan 26, 2026
- Remove unused locale strings (ENTER_TICK_VALUES, ENABLE_CUSTOM_TICK, ADD_CUSTOM_TICK, TICK_VALUE_*_TOOLTIP, REMOVE_TICK) - Update tick settings order numbers to follow X00 pattern for categories (400 instead of 305)
Use tickPositions[i] instead of (i/max) for correct position calculation. Merge a9480c0 added pixel-perfect scaling but incorrectly changed the position lookup from the pre-calculated tickPositions array to a simple division based on loop index, causing ticks to render at wrong positions.
Owner
|
That's very cool, will revisit once LibEQoL is updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
Library Updates: