Fix broken task runner and improve readability medium solution#1
Open
Ferdi-Cocelli wants to merge 1 commit into
Open
Fix broken task runner and improve readability medium solution#1Ferdi-Cocelli wants to merge 1 commit into
Ferdi-Cocelli wants to merge 1 commit into
Conversation
The run category script expected filenames like 2-medium.ts but the actual task files are just named medium.ts. Updated the difficulty mapping to match the real filenames. The readability medium task uses top level await, which requires ESM. Added "type": "module" to package.json to enable this. Since the helper scripts (run category, decrypt) use require(), they've been renamed from .js to .cjs so Node treats them as CommonJS while the rest of the project runs as ESM. Also refactored the readability medium task itself by splitting the single compound assertion into three separate assertions with descriptive error messages, and destructured response.data to reduce repetition. Ferdi, Christian, Nathan, Henry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run category script expected filenames like 2-medium.ts but the actual task files are just named medium.ts. Updated the difficulty mapping to match the real filenames.
The readability medium task uses top level await, which requires ESM. Added "type": "module" to package.json to enable this. Since the helper scripts (run category, decrypt) use require(), they've been renamed from .js to .cjs so Node treats them as CommonJS while the rest of the project runs as ESM.
Also refactored the readability medium task itself by splitting the single compound assertion into three separate assertions with descriptive error messages, and destructured response.data to reduce repetition.
Ferdi, Christian, Nathan, Henry