Fix broken task runner and improve readability medium solution

package.json

@@ -1,7 +1,8 @@
 {
+  "type": "module",
   "scripts": {
-    "test": "node scripts/run-category.js",
-    "unlock-solution": "node scripts/decrypt.js"
+    "test": "node scripts/run-category.cjs",
+    "unlock-solution": "node scripts/decrypt.cjs"
   },
   "dependencies": {
     "crypto": "^1.0.1",

scripts/decrypt.js → scripts/decrypt.cjs

@@ -1,75 +1,75 @@
-const fs = require("fs");
-const crypto = require("crypto");
-const prompt = require("prompt-sync")({ sigint: true });
-
-const algorithm = "aes-256-gcm";
-
-function decrypt(data, password) {
-  const input = Buffer.from(data, "base64");
-
-  const salt = input.subarray(0, 16);
-  const iv = input.subarray(16, 28);
-  const tag = input.subarray(28, 44);
-  const text = input.subarray(44);
-
-  const key = crypto.scryptSync(password, salt, 32);
-
-  const decipher = crypto.createDecipheriv(algorithm, key, iv);
-  decipher.setAuthTag(tag);
-
-  const decrypted = Buffer.concat([decipher.update(text), decipher.final()]);
-  return decrypted.toString("utf8");
-}
-
-const [, , category, difficulty] = process.argv;
-
-const map = {
-  easy: "easy",
-  medium: "medium",
-  hard: "hard",
-};
-
-const categoryOptions = [
-  "additional",
-  "maintainability",
-  "readability",
-  "scalability",
-];
-
-// Is category parameter valid?
-if (!category || !categoryOptions.includes(category)) {
-  console.error(
-    `Incorrect category flag\n\nExample usage: 'npm run unlock-solution maintainability easy'\n\nOptions are: ${categoryOptions.join(", ")}`,
-  );
-  process.exit(1);
-}
-
-// Is difficulty parameter valid?
-const difficultyOptions = Object.keys(map);
-if (!difficulty || !difficultyOptions.includes(difficulty)) {
-  console.error(
-    `Incorrect category flag\n\nexample usage: 'npm run unlock-solution maintainability easy'\n\nOptions are: ${difficultyOptions.join(", ")}`,
-  );
-  process.exit(1);
-}
-
-const filePath = `solutions/${category}/${map[difficulty]}.ts.enc`;
-
-if (!fs.existsSync(filePath)) {
-  console.error("File not found:", filePath);
-  process.exit(1);
-}
-
-const password = prompt("Enter decryption password: ");
-
-const encrypted = fs.readFileSync(filePath, "utf8");
-
-try {
-  const decrypted = decrypt(encrypted, password.trim().toLowerCase());
-  fs.writeFileSync(filePath.replace(".ts.enc", ".ts"), decrypted);
-  fs.unlinkSync(filePath);
-  fs.del;
-} catch (e) {
-  console.error("Wrong decryption password...");
-  process.exit(0);
-}
+const fs = require("fs");
+const crypto = require("crypto");
+const prompt = require("prompt-sync")({ sigint: true });
+
+const algorithm = "aes-256-gcm";
+
+function decrypt(data, password) {
+  const input = Buffer.from(data, "base64");
+
+  const salt = input.subarray(0, 16);
+  const iv = input.subarray(16, 28);
+  const tag = input.subarray(28, 44);
+  const text = input.subarray(44);
+
+  const key = crypto.scryptSync(password, salt, 32);
+
+  const decipher = crypto.createDecipheriv(algorithm, key, iv);
+  decipher.setAuthTag(tag);
+
+  const decrypted = Buffer.concat([decipher.update(text), decipher.final()]);
+  return decrypted.toString("utf8");
+}
+
+const [, , category, difficulty] = process.argv;
+
+const map = {
+  easy: "easy",
+  medium: "medium",
+  hard: "hard",
+};
+
+const categoryOptions = [
+  "additional",
+  "maintainability",
+  "readability",
+  "scalability",
+];
+
+// Is category parameter valid?
+if (!category || !categoryOptions.includes(category)) {
+  console.error(
+    `Incorrect category flag\n\nExample usage: 'npm run unlock-solution maintainability easy'\n\nOptions are: ${categoryOptions.join(", ")}`,
+  );
+  process.exit(1);
+}
+
+// Is difficulty parameter valid?
+const difficultyOptions = Object.keys(map);
+if (!difficulty || !difficultyOptions.includes(difficulty)) {
+  console.error(
+    `Incorrect category flag\n\nexample usage: 'npm run unlock-solution maintainability easy'\n\nOptions are: ${difficultyOptions.join(", ")}`,
+  );
+  process.exit(1);
+}
+
+const filePath = `solutions/${category}/${map[difficulty]}.ts.enc`;
+
+if (!fs.existsSync(filePath)) {
+  console.error("File not found:", filePath);
+  process.exit(1);
+}
+
+const password = prompt("Enter decryption password: ");
+
+const encrypted = fs.readFileSync(filePath, "utf8");
+
+try {
+  const decrypted = decrypt(encrypted, password.trim().toLowerCase());
+  fs.writeFileSync(filePath.replace(".ts.enc", ".ts"), decrypted);
+  fs.unlinkSync(filePath);
+  fs.del;
+} catch (e) {
+  console.error("Wrong decryption password...");
+  process.exit(0);
+}

scripts/run-category.js → scripts/run-category.cjs

@@ -1,34 +1,34 @@
-const { execSync } = require("child_process");
-
-const category = process.argv[2];
-const difficulty = process.argv[3];
-
-const map = {
-  easy: "1-easy",
-  medium: "2-medium",
-  hard: "3-hard",
-};
-
-// Is category parameter valid?
-const categoryOptions = ["maintainability", "readability", "scalability"];
-if (!category || !categoryOptions.includes(category)) {
-  console.error(
-    `Incorrect category flag\n\nExample usage: 'npm run test maintainability easy'\n\nOptions are: ${categoryOptions.join(", ")}`,
-  );
-  process.exit(1);
-}
-
-// Is difficulty parameter valid?
-const difficultyOptions = Object.keys(map);
-if (!difficulty || !difficultyOptions.includes(difficulty)) {
-  console.error(
-    `Incorrect category flag\n\nexample usage: 'npm run test maintainability easy'\n\nOptions are: ${difficultyOptions.join(", ")}`,
-  );
-  process.exit(1);
-}
-
-const file = `tasks/${category}/${map[difficulty]}.ts`;
-
-execSync(`npx tsx ${file}`, {
-  stdio: "inherit",
-});
+const { execSync } = require("child_process");
+
+const category = process.argv[2];
+const difficulty = process.argv[3];
+
+const map = {
+  easy: "easy",
+  medium: "medium",
+  hard: "hard",
+};
+
+// Is category parameter valid?
+const categoryOptions = ["maintainability", "readability", "scalability"];
+if (!category || !categoryOptions.includes(category)) {
+  console.error(
+    `Incorrect category flag\n\nExample usage: 'npm run test maintainability easy'\n\nOptions are: ${categoryOptions.join(", ")}`,
+  );
+  process.exit(1);
+}
+
+// Is difficulty parameter valid?
+const difficultyOptions = Object.keys(map);
+if (!difficulty || !difficultyOptions.includes(difficulty)) {
+  console.error(
+    `Incorrect category flag\n\nexample usage: 'npm run test maintainability easy'\n\nOptions are: ${difficultyOptions.join(", ")}`,
+  );
+  process.exit(1);
+}
+
+const file = `tasks/${category}/${map[difficulty]}.ts`;
+
+execSync(`npx tsx ${file}`, {
+  stdio: "inherit",
+});

tasks/readability/medium.ts

@@ -11,9 +11,8 @@ import assert from "node:assert";
  */
 
 const response = await api.get("/user/1");
+const { roles, status, profile } = response.data;
 
-assert(
-  response.data.roles.includes("admin") &&
-    response.data.status === "active" &&
-    response.data.profile.completed === true,
-);
+assert(roles.includes("admin"), "Expected user to have admin role");
+assert(status === "active", "Expected user status to be active");
+assert(profile.completed === true, "Expected user profile to be complete");