-
Notifications
You must be signed in to change notification settings - Fork 241
Refactor artifacts detection + add sturation detection #4297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor artifacts detection + add sturation detection #4297
Conversation
|
@samuelgarcia do not forget, in this PR, to change DetectThresholdCrossing(recording, ...) to DetectThresholdCrossing(envelope, ...) in the detec_period_artefacts_by_envelope |
|
Hi @oliche @JoeZiminski I think we do not need to scaled traces at each chunk we could only could the unscaled threhold in the init and then we could avoid the costly convertion to float32 or float64. Also I put the unit in uV to be more SI friendly. |
|
@alejoe91 @chrishalcrow ready to review on my side |
| random_slices_kwargs["seed"] = seed | ||
| noise_levels = get_noise_levels(envelope, return_in_uV=False, random_slices_kwargs=random_slices_kwargs) | ||
|
|
||
| node0 = _DetectThresholdCrossing( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be envelope here, am I right?
@JoeZiminski @oliche
This refactor the artifact detection and blanking
detect_artifact_periods()time to be used in preprocess dict (@chrishalcrow this is for you)
Could also be done in this PR:
To be done in 2 futures PR: