-
Notifications
You must be signed in to change notification settings - Fork 241
Compute saturation intervals ala IBL #4301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…ace into sat_detection
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ace into sat_detection
alejoe91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we apply this directly in the int16 space?
|
Hi @oliche @JoeZiminski I think we do not need to scaled traces at each chunk we could only could the unscaled threhold in the init and then we could avoid the costly convertion to float32 or float64. Also I put the unit in uV to be more SI friendly. |
This PR ports the saturation method from IBL. It will introduce a new data type for holding information on events / periods of noise / saturation etc.
This will also require:
silence_periods.pyto handle this new data typeOther notes:
remove_artefacts.pyhandles a slightly different use case (triggers at known timepoints contaminating the recording, which may also be imputed with a model-based approach) and so is not considered hereQuestions:
computethe data is cast tofloat64and then scaled withgainsandoffset. To confirm, is there any situation where this data might already be scaled? I guess if the data is scaled, gain is1and offset is0anyway.float64was chosen for the extra precision as IBL are working in voltsmute_window_samplesbe scaled based on thefs? (currently 7 samples assumes NP1)return_scaledorscale_to_uVpreferred now? Just a note in the docstringdetect_saturation()docstring? I will also double check but good to get another pair of eyes on thisTo discuss
Documentation
It would be nice to add a documentation page for this once the applier-function is done as the application is a little non-standard i.e. should be estimated on the raw data, and applied on the preprocessed data. Some of the values should also be empirically estimated / are dependent on the probe, this has really designed for NP1 as I understand it.