Enhancement os aware dark/light theme persistence#223
Open
amoduenechojo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes
#166
The theme experience now behaves as requested:
The app checks the user’s OS preference with matchMedia on initial load.
A manual theme choice is saved to localStorage and takes precedence over the OS default.
A blocking inline script applies the theme class before React hydrates, preventing the opposite theme from flashing.
What changed
Added browser-side theme initialization and persistence logic in themeService.ts
Updated the theme hook in useTheme.ts to initialize from stored/local preference first, then fall back safely
Wired the pre-hydration theme script into layout.tsx
Kept the theme provider aligned in providers.tsx
Added regression coverage in useTheme.test.ts