Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import TopLoader from '@/components/ui/TopLoader';
import CommandPalette from '@/components/ui/CommandPalette';
import ToastProvider from '@/components/providers/ToastProvider';
import ModalProvider from '@/components/providers/ModalProvider';
import { themeService } from '@/services/themeService';

export const metadata = {
title: 'SwiftChain',
Expand All @@ -21,6 +22,11 @@ export default function RootLayout({
}) {
return (
<html lang="en" suppressHydrationWarning>
<head>
<script
dangerouslySetInnerHTML={{ __html: themeService.getThemeScript() }}
/>
</head>
<body>
<ModalProvider>
<Providers>
Expand Down
29 changes: 28 additions & 1 deletion hooks/__tests__/useTheme.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { act, renderHook } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { useTheme } from '@/hooks/useTheme';
import { themeService } from '@/services/themeService';

Expand All @@ -11,6 +11,11 @@ jest.mock('next-themes', () => ({

jest.mock('@/services/themeService', () => ({
themeService: {
getStoredThemePreference: jest.fn(() => null),
setStoredThemePreference: jest.fn(),
getInitialTheme: jest.fn(() => 'light'),
getThemeScript: jest.fn(() => ''),
applyTheme: jest.fn(),
getThemePreference: jest.fn(),
saveThemePreference: jest.fn(),
},
Expand Down Expand Up @@ -62,6 +67,28 @@ describe('useTheme', () => {
expect(themeService.saveThemePreference).toHaveBeenCalledWith('light');
});

it('should prefer the stored local override over the backend/system theme on load', async () => {
window.localStorage.setItem('theme', 'light');
(themeService.getStoredThemePreference as jest.Mock).mockReturnValue('light');
window.matchMedia = jest.fn().mockImplementation((query: string) => ({
matches: query === '(prefers-color-scheme: dark)',
media: query,
addEventListener: jest.fn(),
removeEventListener: jest.fn(),
addListener: jest.fn(),
removeListener: jest.fn(),
dispatchEvent: jest.fn(),
})) as typeof window.matchMedia;

const { result } = renderHook(() => useTheme());

await waitFor(() => {
expect(mockSetTheme).toHaveBeenCalledWith('light');
});

expect(result.current.resolvedTheme).toBe('light');
});

it('should not throw when persistence fails', async () => {
(themeService.saveThemePreference as jest.Mock).mockRejectedValueOnce(
new Error('Persistence failed')
Expand Down
21 changes: 20 additions & 1 deletion hooks/useTheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,32 @@ export function useTheme() {
let isMounted = true;

const loadThemePreference = async () => {
const storedTheme = themeService.getStoredThemePreference();

if (storedTheme) {
themeService.applyTheme(storedTheme);
setTheme(storedTheme);
return;
}

try {
const data = await themeService.getThemePreference();
if (!isMounted) {
return;
}

if (data.theme === 'system') {
themeService.applyTheme('system');
setTheme('system');
return;
}

themeService.applyTheme(data.theme);
setTheme(data.theme);
} catch {
// Keep next-themes default behavior (system) on failures.
const fallbackTheme = themeService.getInitialTheme();
themeService.applyTheme(fallbackTheme);
setTheme(fallbackTheme);
}
};

Expand All @@ -29,6 +47,7 @@ export function useTheme() {

const updateTheme = useCallback(
async (nextTheme: ThemePreference): Promise<void> => {
themeService.applyTheme(nextTheme);
setTheme(nextTheme);

try {
Expand Down
82 changes: 82 additions & 0 deletions services/themeService.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,98 @@
import axios from 'axios';

const API_BASE_URL = process.env.NEXT_PUBLIC_API_URL ?? '';
const THEME_STORAGE_KEY = 'theme';
const COLOR_SCHEME_QUERY = '(prefers-color-scheme: dark)';

export type ThemePreference = 'light' | 'dark' | 'system';

interface ThemePreferenceResponse {
theme: ThemePreference;
}

function isThemePreference(value: string | null): value is ThemePreference {
return value === 'light' || value === 'dark' || value === 'system';
}

function getSystemTheme(): 'light' | 'dark' {
if (typeof window === 'undefined' || typeof window.matchMedia !== 'function') {
return 'light';
}

return window.matchMedia(COLOR_SCHEME_QUERY).matches ? 'dark' : 'light';
}

function applyThemeClass(theme: 'light' | 'dark') {
if (typeof document === 'undefined') {
return;
}

const root = document.documentElement;
root.classList.toggle('dark', theme === 'dark');
root.style.colorScheme = theme;
root.setAttribute('data-theme', theme);
}

/**
* Handles theme preference API communication.
* Hooks consume this service; UI components do not.
*/
export const themeService = {
getStoredThemePreference(): ThemePreference | null {
if (typeof window === 'undefined') {
return null;
}

const storedTheme = window.localStorage.getItem(THEME_STORAGE_KEY);
return isThemePreference(storedTheme) ? storedTheme : null;
},

setStoredThemePreference(theme: ThemePreference) {
if (typeof window === 'undefined') {
return;
}

if (theme === 'system') {
window.localStorage.removeItem(THEME_STORAGE_KEY);
return;
}

window.localStorage.setItem(THEME_STORAGE_KEY, theme);
},

getInitialTheme(): 'light' | 'dark' {
const storedTheme = this.getStoredThemePreference();
if (storedTheme === 'light' || storedTheme === 'dark') {
return storedTheme;
}

return getSystemTheme();
},

getThemeScript(): string {
return `
(function() {
const storageKey = '${THEME_STORAGE_KEY}';
const mediaQuery = window.matchMedia('(prefers-color-scheme: dark)');
const storedTheme = window.localStorage.getItem(storageKey);
const isDark = storedTheme === 'dark' || (!storedTheme && mediaQuery.matches);
const root = document.documentElement;
root.classList.toggle('dark', isDark);
root.style.colorScheme = isDark ? 'dark' : 'light';
root.setAttribute('data-theme', isDark ? 'dark' : 'light');
})();
`;
},

applyTheme(theme: ThemePreference | 'light' | 'dark') {
if (theme === 'system') {
applyThemeClass(getSystemTheme());
return;
}

applyThemeClass(theme);
},

async getThemePreference(): Promise<ThemePreferenceResponse> {
const { data } = await axios.get<ThemePreferenceResponse>(
`${API_BASE_URL}/api/user/preferences/theme`
Expand All @@ -23,6 +103,8 @@ export const themeService = {
async saveThemePreference(
theme: ThemePreference
): Promise<ThemePreferenceResponse> {
this.setStoredThemePreference(theme);

const { data } = await axios.post<ThemePreferenceResponse>(
`${API_BASE_URL}/api/user/preferences/theme`,
{ theme }
Expand Down
Loading