feat(e2e): unskip event tests #1428

Copilot · 2026-02-02T00:59:42Z

12 e2e tests were unconditionally skipped. Unskipped all tests and fixed issues preventing them from passing.

Changes

Removed unconditional skips from 12 tests across all-day, someday, and timed event flows
Added conditional mobile skips for keyboard shortcuts and mouse-based week view interactions (desktop-only features)
Fixed all-day mouse tests to use openEventForEditingWithMouse() helper instead of direct button clicks, ensuring form visibility before interaction
Added 1000ms wait in someday keyboard update test after event creation to prevent race condition (consistent with timed event tests)

Result

40 tests passing (including all previously skipped tests)
18 tests appropriately skipped on mobile

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

accounts.google.com
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD lit _universe_cnf_Cosystemctl (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD b (dns block)
esm.ubuntu.com
- Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)
fonts.googleapis.com
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD lit _universe_cnf_Cosystemctl (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD b (dns block)
us-assets.i.posthog.com
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD lit _universe_cnf_Cosystemctl (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD b (dns block)
us.i.posthog.com
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD lit _universe_cnf_Cosystemctl (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1194/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,RenderD b (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Write e2e tests</issue_title>
<issue_description>We have a lot of skipped e2e tests. Unskip them and update them until they pass as needed</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Write baseline e2e tests #1427

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: tyler-dane <30163055+tyler-dane@users.noreply.github.com>

Copilot

Pull request overview

This PR successfully unskips 12 previously disabled e2e tests and implements necessary fixes to make them pass. The changes improve test reliability by adding conditional mobile skips, using more robust helper functions, and addressing race conditions.

Changes:

Removed unconditional test.skip() calls from 12 e2e tests across all-day, someday, and timed event flows
Added conditional mobile skips for keyboard shortcuts and mouse-based week view interactions (desktop-only features)
Refactored all-day mouse tests to use openEventForEditingWithMouse() helper instead of direct button clicks for better reliability
Added 1000ms wait in someday keyboard update test to prevent race condition

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
e2e/timed/update-event-keyboard.spec.ts	Added conditional mobile skip, unskipped test
e2e/timed/delete-event-mouse.spec.ts	Added conditional mobile skip, unskipped test
e2e/someday/update-someday-event-mouse.spec.ts	Unskipped test (already had conditional mobile skip)
e2e/someday/update-someday-event-keyboard.spec.ts	Unskipped test, added 1000ms wait to prevent race condition
e2e/someday/delete-someday-event-mouse.spec.ts	Unskipped test (already had conditional mobile skip)
e2e/someday/delete-someday-event-keyboard.spec.ts	Unskipped test (already had conditional mobile skip)
e2e/allday/update-allday-event-mouse.spec.ts	Unskipped test, replaced direct click with `openEventForEditingWithMouse()` helper, added helper import
e2e/allday/update-allday-event-keyboard.spec.ts	Added conditional mobile skip, unskipped test
e2e/allday/delete-allday-event-mouse.spec.ts	Added conditional mobile skip, replaced direct click with `openEventForEditingWithMouse()` helper, added helper import, unskipped test
e2e/allday/delete-allday-event-keyboard.spec.ts	Added conditional mobile skip, unskipped test
e2e/allday/create-allday-event-mouse.spec.ts	Added conditional mobile skip, unskipped test
e2e/allday/create-allday-event-keyboard.spec.ts	Added conditional mobile skip, unskipped test

Copilot · 2026-02-02T02:56:54Z

e2e/someday/update-someday-event-keyboard.spec.ts

  await openSomedayEventFormWithKeyboard(page);
  await fillTitleAndSaveWithKeyboard(page, title);
  await expectSomedayEventVisible(page, title);
+  await page.waitForTimeout(1000);


The wait timeout added here addresses the race condition consistently with other keyboard tests. However, the corresponding someday delete keyboard test (delete-someday-event-keyboard.spec.ts) was not updated with this same fix. For consistency and to prevent the same race condition, that test should also include this wait.

Copilot · 2026-02-02T02:56:55Z

e2e/timed/update-event-keyboard.spec.ts

 } from "../utils/event-test-utils";

-test.skip("should update a timed event using keyboard interaction", async ({
+test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");


Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change

test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");

test.skip(

({ isMobile }) => isMobile,

"Keyboard shortcuts are desktop-only.",

);

Copilot · 2026-02-02T02:56:55Z

e2e/allday/update-allday-event-keyboard.spec.ts

 } from "../utils/event-test-utils";

-test.skip("should update an all-day event using keyboard interaction", async ({
+test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");


Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change

test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");

test.skip(

({ isMobile }) => isMobile,

"Keyboard shortcuts are desktop-only.",

);

Copilot · 2026-02-02T02:56:55Z

e2e/allday/delete-allday-event-keyboard.spec.ts

 } from "../utils/event-test-utils";

-test.skip("should delete an all-day event using keyboard interaction", async ({
+test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");


Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change

test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");

test.skip(

({ isMobile }) => isMobile,

"Keyboard shortcuts are desktop-only.",

);

Copilot · 2026-02-02T02:56:55Z

e2e/allday/create-allday-event-keyboard.spec.ts

 } from "../utils/event-test-utils";

-test.skip("should create an all-day event using keyboard interaction", async ({
+test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");


Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change

test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");

test.skip(

({ isMobile }) => isMobile,

"Keyboard shortcuts are desktop-only.",

);

Initial plan

45a11ab

Copilot AI assigned Copilot and tyler-dane Feb 2, 2026

Copilot started work on behalf of tyler-dane February 2, 2026 01:00 View session

Copilot AI and others added 3 commits February 2, 2026 01:02

Unskip all 12 e2e tests

2f16e20

Co-authored-by: tyler-dane <30163055+tyler-dane@users.noreply.github.com>

Add mobile skip conditions to all-day and timed tests

a454227

Co-authored-by: tyler-dane <30163055+tyler-dane@users.noreply.github.com>

Fix all-day mouse tests and add timing fix for someday keyboard test

22c3b1c

Co-authored-by: tyler-dane <30163055+tyler-dane@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Unskip and update e2e tests until they pass~~ Unskip and fix 12 e2e tests Feb 2, 2026

Copilot AI requested a review from tyler-dane February 2, 2026 01:21

Copilot finished work on behalf of tyler-dane February 2, 2026 01:21

Merge branch 'main' into copilot/unskip-e2e-tests

c8d23b0

tyler-dane marked this pull request as ready for review February 2, 2026 02:53

Copilot AI review requested due to automatic review settings February 2, 2026 02:53

tyler-dane changed the title ~~Unskip and fix 12 e2e tests~~ feat(e2e): unskip tests Feb 2, 2026

Copilot started reviewing on behalf of tyler-dane February 2, 2026 02:53 View session

tyler-dane changed the title ~~feat(e2e): unskip tests~~ feat(e2e): unskip event tests Feb 2, 2026

tyler-dane merged commit 8f73d8c into main Feb 2, 2026
9 checks passed

tyler-dane deleted the copilot/unskip-e2e-tests branch February 2, 2026 02:55

Copilot AI reviewed Feb 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(e2e): unskip event tests #1428

feat(e2e): unskip event tests #1428

Uh oh!

Copilot AI commented Feb 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(e2e): unskip event tests #1428

feat(e2e): unskip event tests #1428

Uh oh!

Conversation

Copilot AI commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Result

I tried to connect to the following addresses, but was blocked by firewall rules:

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 2, 2026 •

edited

Loading