Skip to content

feat(e2e): unskip event tests #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyler-dane merged 5 commits into from
Feb 2, 2026
Merged

feat(e2e): unskip event tests #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45a11ab
Initial plan
Copilot Feb 2, 2026
2f16e20
Unskip all 12 e2e tests
Copilot Feb 2, 2026
a454227
Add mobile skip conditions to all-day and timed tests
Copilot Feb 2, 2026
22c3b1c
Fix all-day mouse tests and add timing fix for someday keyboard test
Copilot Feb 2, 2026
c8d23b0
Merge branch 'main' into copilot/unskip-e2e-tests
tyler-dane Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion e2e/allday/create-allday-event-keyboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import {
prepareCalendarPage,
} from "../utils/event-test-utils";

test.skip("should create an all-day event using keyboard interaction", async ({
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
test.skip(
({ isMobile }) => isMobile,
"Keyboard shortcuts are desktop-only.",
);

Copilot uses AI. Check for mistakes.

test("should create an all-day event using keyboard interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
7 changes: 6 additions & 1 deletion e2e/allday/create-allday-event-mouse.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ import {
prepareCalendarPage,
} from "../utils/event-test-utils";

test.skip("should create an all-day event using mouse interaction", async ({
test.skip(
({ isMobile }) => isMobile,
"Mouse flows are desktop-only in week view.",
);

test("should create an all-day event using mouse interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
4 changes: 3 additions & 1 deletion e2e/allday/delete-allday-event-keyboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import {
prepareCalendarPage,
} from "../utils/event-test-utils";

test.skip("should delete an all-day event using keyboard interaction", async ({
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
test.skip(
({ isMobile }) => isMobile,
"Keyboard shortcuts are desktop-only.",
);

Copilot uses AI. Check for mistakes.

test("should delete an all-day event using keyboard interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
10 changes: 8 additions & 2 deletions e2e/allday/delete-allday-event-mouse.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,16 @@ import {
expectAllDayEventVisible,
fillTitleAndSaveWithMouse,
openAllDayEventFormWithMouse,
openEventForEditingWithMouse,
prepareCalendarPage,
} from "../utils/event-test-utils";

test.skip("should delete an all-day event using mouse interaction", async ({
test.skip(
({ isMobile }) => isMobile,
"Mouse flows are desktop-only in week view.",
);

test("should delete an all-day event using mouse interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand All @@ -19,7 +25,7 @@ test.skip("should delete an all-day event using mouse interaction", async ({
await fillTitleAndSaveWithMouse(page, title);
await expectAllDayEventVisible(page, title);

await page.locator("#allDayRow").getByRole("button", { name: title }).click();
await openEventForEditingWithMouse(page, title);
await deleteEventWithMouse(page);

await expectAllDayEventMissing(page, title);
Expand Down
4 changes: 3 additions & 1 deletion e2e/allday/update-allday-event-keyboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import {
updateEventTitle,
} from "../utils/event-test-utils";

test.skip("should update an all-day event using keyboard interaction", async ({
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
test.skip(
({ isMobile }) => isMobile,
"Keyboard shortcuts are desktop-only.",
);

Copilot uses AI. Check for mistakes.

test("should update an all-day event using keyboard interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
5 changes: 3 additions & 2 deletions e2e/allday/update-allday-event-mouse.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
expectAllDayEventVisible,
fillTitleAndSaveWithMouse,
openAllDayEventFormWithMouse,
openEventForEditingWithMouse,
prepareCalendarPage,
updateEventTitle,
} from "../utils/event-test-utils";
Expand All @@ -14,7 +15,7 @@ test.skip(
"Mouse flows are desktop-only in week view.",
);

test.skip("should update an all-day event using mouse interaction", async ({
test("should update an all-day event using mouse interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand All @@ -24,7 +25,7 @@ test.skip("should update an all-day event using mouse interaction", async ({
await fillTitleAndSaveWithMouse(page, title);
await expectAllDayEventVisible(page, title);

await page.locator("#allDayRow").getByRole("button", { name: title }).click();
await openEventForEditingWithMouse(page, title);

const updatedTitle = updateEventTitle("All-Day Event");
await fillTitleAndSaveWithMouse(page, updatedTitle);
Expand Down
2 changes: 1 addition & 1 deletion e2e/someday/delete-someday-event-keyboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {

test.skip(({ isMobile }) => isMobile, "Someday sidebar is desktop-only.");

test.skip("should delete a someday event using keyboard interaction", async ({
test("should delete a someday event using keyboard interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
2 changes: 1 addition & 1 deletion e2e/someday/delete-someday-event-mouse.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {

test.skip(({ isMobile }) => isMobile, "Someday sidebar is desktop-only.");

test.skip("should delete a someday event using mouse interaction", async ({
test("should delete a someday event using mouse interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
3 changes: 2 additions & 1 deletion e2e/someday/update-someday-event-keyboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {

test.skip(({ isMobile }) => isMobile, "Someday sidebar is desktop-only.");

test.skip("should update a someday event using keyboard interaction", async ({
test("should update a someday event using keyboard interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand All @@ -21,6 +21,7 @@ test.skip("should update a someday event using keyboard interaction", async ({
await openSomedayEventFormWithKeyboard(page);
await fillTitleAndSaveWithKeyboard(page, title);
await expectSomedayEventVisible(page, title);
await page.waitForTimeout(1000);
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wait timeout added here addresses the race condition consistently with other keyboard tests. However, the corresponding someday delete keyboard test (delete-someday-event-keyboard.spec.ts) was not updated with this same fix. For consistency and to prevent the same race condition, that test should also include this wait.

Copilot uses AI. Check for mistakes.

await openEventForEditingWithKeyboard(page, title);

Expand Down
2 changes: 1 addition & 1 deletion e2e/someday/update-someday-event-mouse.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {

test.skip(({ isMobile }) => isMobile, "Someday sidebar is desktop-only.");

test.skip("should update a someday event using mouse interaction", async ({
test("should update a someday event using mouse interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
7 changes: 6 additions & 1 deletion e2e/timed/delete-event-mouse.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ import {
prepareCalendarPage,
} from "../utils/event-test-utils";

test.skip("should delete a timed event using mouse interaction", async ({
test.skip(
({ isMobile }) => isMobile,
"Mouse flows are desktop-only in week view.",
);

test("should delete a timed event using mouse interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
4 changes: 3 additions & 1 deletion e2e/timed/update-event-keyboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import {
updateEventTitle,
} from "../utils/event-test-utils";

test.skip("should update a timed event using keyboard interaction", async ({
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting inconsistency: keyboard test skips use single-line format test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only."); while mouse test skips use multi-line format. For consistency across the codebase, keyboard tests should use the same formatting as mouse tests, or vice versa.

Suggested change
test.skip(({ isMobile }) => isMobile, "Keyboard shortcuts are desktop-only.");
test.skip(
({ isMobile }) => isMobile,
"Keyboard shortcuts are desktop-only.",
);

Copilot uses AI. Check for mistakes.

test("should update a timed event using keyboard interaction", async ({
page,
}) => {
await prepareCalendarPage(page);
Expand Down
Loading