fix(ui): build live indicator glyph at runtime to avoid release-mode mojibake - #118
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: b6de892 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
devin-ai-integration
Bot
changed the title
devin-ai-integration
Bot
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
MattiasBuelens
requested changes
Jul 3, 2026
devin-ai-integration
Bot
force-pushed
the
devin/1783083509-fix-live-indicator-mojibake
branch
from
July 3, 2026 13:35
44774d0 to
73587ba
Compare
devin-ai-integration
Bot
changed the title
MattiasBuelens
approved these changes
Jul 3, 2026
MattiasBuelens
self-requested a review
July 3, 2026 13:50
…mojibake Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
devin-ai-integration
Bot
force-pushed
the
devin/1783083509-fix-live-indicator-mojibake
branch
from
July 3, 2026 13:51
733895a to
c5b7ca5
Compare
devin-ai-integration
Bot
changed the title
MattiasBuelens
approved these changes
Jul 3, 2026
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
devin-ai-integration
Bot
force-pushed
the
devin/1783083509-fix-live-indicator-mojibake
branch
from
July 3, 2026 13:53
c5b7ca5 to
b6de892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The live indicator
●(U+25CF) rendered as mojibakeâ—in web release builds. It was a raw non-ASCII glyph in the output bundle, and correct display depended on the served bundle being decoded as UTF-8 — not guaranteed across static hosts/CDNs (dev works only because webpack-dev-server sendscharset=utf-8). A source escape (\u25CF) doesn't help: terser un-escapes it back to the raw glyph during minification.Fix: keep the
●out of the source entirely and build it at runtime, so the emitted bundle stays ASCII (terser won't constant-foldString.fromCodePointunlessunsafeis enabled).Verified: the
web-releasebundle no longer contains the raw●byte sequence (E2 97 8F) and the runtimefromCodePoint(9679)call survives minification; lint/prettier pass.Link to Devin session: https://dolby.devinenterprise.com/sessions/53b41d6c6beb4b88984929b5cc172d73
Requested by: @tvanlaerhoven