Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/live-indicator-web-release.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@theoplayer/react-native-ui': patch
---

Fixed an issue on Web where the live indicator was rendered as a corrupted character (mojibake) in release builds.
36 changes: 36 additions & 0 deletions REVIEW.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Code Review Guidelines

**Be VERY concise.**

## Checklist

### Changeset

Every PR that changes runtime behavior **must** include a changeset entry in `.changeset/`.

If one is missing, suggest adding a file `.changeset/<short-slug>.md`:

```md
---
'@theoplayer/react-native-ui': patch|minor|major
---

<One-line description of the change. End with a full stop.>
```

Use `patch` for bug fixes, `minor` for new features, `major` for breaking changes.

### API surface

- Public API changes must be exported from the package entry (`src/index.tsx`).
- Avoid breaking existing public types without a major version bump.

### Docs

- Public API needs TSDoc comments — `npm run docs` runs TypeDoc with `--treatWarningsAsErrors`, so undocumented or broken references fail.

### Code quality

- No `eslint-disable` or `@ts-ignore` without justification.
- Prettier is enforced via pre-commit hook (`printWidth: 150`); don't manually override.
- Avoid embedding raw non-ASCII characters in source; they can break in minified/release web bundles.
2 changes: 1 addition & 1 deletion src/ui/components/button/GoToLiveButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function GoToLiveButton(props: LiveButtonProps) {
onPress={goToLive}
touchable={true}>
<View style={{ flexDirection: 'row', alignItems: 'center' }}>
<Text style={[context.style.text, { color: liveIndicatorColor, marginRight: 6 }]}></Text>
Comment thread
MattiasBuelens marked this conversation as resolved.
<Text style={[context.style.text, { color: liveIndicatorColor, marginRight: 6 }]}>{String.fromCodePoint(9679)}</Text>
<Text style={[context.style.text, { color: context.style.colors.text }, textStyle]}>{context.locale.liveLabel}</Text>
</View>
</ActionButton>
Expand Down
Loading