-
Notifications
You must be signed in to change notification settings - Fork 5
fix(ui): build live indicator glyph at runtime to avoid release-mode mojibake #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tvanlaerhoven
merged 2 commits into
main
from
devin/1783083509-fix-live-indicator-mojibake
Jul 3, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@theoplayer/react-native-ui': patch | ||
| --- | ||
|
|
||
| Fixed an issue on Web where the live indicator was rendered as a corrupted character (mojibake) in release builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Code Review Guidelines | ||
|
|
||
| **Be VERY concise.** | ||
|
|
||
| ## Checklist | ||
|
|
||
| ### Changeset | ||
|
|
||
| Every PR that changes runtime behavior **must** include a changeset entry in `.changeset/`. | ||
|
|
||
| If one is missing, suggest adding a file `.changeset/<short-slug>.md`: | ||
|
|
||
| ```md | ||
| --- | ||
| '@theoplayer/react-native-ui': patch|minor|major | ||
| --- | ||
|
|
||
| <One-line description of the change. End with a full stop.> | ||
| ``` | ||
|
|
||
| Use `patch` for bug fixes, `minor` for new features, `major` for breaking changes. | ||
|
|
||
| ### API surface | ||
|
|
||
| - Public API changes must be exported from the package entry (`src/index.tsx`). | ||
| - Avoid breaking existing public types without a major version bump. | ||
|
|
||
| ### Docs | ||
|
|
||
| - Public API needs TSDoc comments — `npm run docs` runs TypeDoc with `--treatWarningsAsErrors`, so undocumented or broken references fail. | ||
|
|
||
| ### Code quality | ||
|
|
||
| - No `eslint-disable` or `@ts-ignore` without justification. | ||
| - Prettier is enforced via pre-commit hook (`printWidth: 150`); don't manually override. | ||
| - Avoid embedding raw non-ASCII characters in source; they can break in minified/release web bundles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.