Feat: Add function for Epidemiological time plot"#11
Open
Conversation
…nction was divided into subfunctions
GeraldineGomez
requested changes
Feb 7, 2025
| #' | ||
| #' @export | ||
| get_historic_epi_times <- function(tabla) { | ||
| data <- tabla |
Collaborator
There was a problem hiding this comment.
Please avoid using data since it is a reserved word in R and in other packages.
R/cleaning_data.R
Outdated
| #' @param dataset Un dataset con nombres de columna a limpiar. | ||
| #' @return Un dataset con nombres de columna estandarizados. | ||
| #' @export | ||
| clean_colnames_spaces <- function(df) { |
Collaborator
There was a problem hiding this comment.
Rename param df to dataset, according to the function documentation
R/cleaning_data.R
Outdated
Comment on lines
190
to
240
| janitor::clean_names() %>% | ||
| fill_down_column("anos") %>% | ||
| fill_down_column("ano") %>% | ||
| fill_down_column("periodo_epidemiologico") |
Collaborator
There was a problem hiding this comment.
Please check if it is possible to include the column names in the configuration file.
R/import_data.R
Outdated
| get_selected_table <- function(list_of_tables, indicator) { | ||
| # Verificar que 'tables' es una lista | ||
| if (!is.list(tables)) { | ||
| if (!is.list(list_of_tables)) { |
Collaborator
There was a problem hiding this comment.
Avoid use words like of
R/plotting_data.R
Outdated
Comment on lines
307
to
320
| plot_historic_epi_time <- function(df, bars_df, lines_df, periodo_epi ) { | ||
| plot_historic_epi_time <- function(dataset_epiTime, periodo_epi ) { |
Collaborator
There was a problem hiding this comment.
Please replace dataset_epiTime with dataset_epi_time
… also cleaned up the syntaxis of the code in the skeleton.rmd file .
… also cleaned up the syntaxis of the code in the skeleton.rmd file .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.