bug: fix the editbility of data in some cases#151
Merged
debba merged 1 commit intoTabularisDB:mainfrom Apr 24, 2026
Merged
Conversation
Collaborator
|
Great catch @thomaswasle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-database MySQL connections, fetchPkColumn always fell back to activeSchema when
resolving which database to query for column metadata. Since MySQL has schemas: false,
activeSchema is null, so the backend fell back to params.database.primary() — the first database
in the selection.
Tables opened from a non-primary selected database would have their columns queried from the
wrong database. get_columns would return no results, pkColumn would be set to null, and the
DataGrid would be read-only even for tables with a proper primary key.
Query execution was unaffected because it correctly used targetTab?.schema rather than
activeSchema.
Fix: Add an optional tabSchema parameter to fetchPkColumn and pass targetTab?.schema at the call
site, so column metadata is always fetched from the same database the query runs against.