Skip to content

bug: fix the editbility of data in some cases #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debba merged 1 commit into from
Apr 24, 2026
Merged

bug: fix the editbility of data in some cases #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pages/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,13 +493,14 @@ export const Editor = () => {
}, [tabs, updateScrollArrows]);

const fetchPkColumn = useCallback(
async (table: string, tabId?: string) => {
async (table: string, tabId?: string, tabSchema?: string) => {
if (!activeConnectionId) return;
const effectiveSchema = tabSchema ?? activeSchema;
try {
const cols = await invoke<TableColumn[]>("get_columns", {
connectionId: activeConnectionId,
tableName: table,
...(activeSchema ? { schema: activeSchema } : {}),
...(effectiveSchema ? { schema: effectiveSchema } : {}),
});
const pk = cols.find((c) => c.is_pk);
const autoInc = cols
Expand Down Expand Up @@ -683,7 +684,7 @@ export const Editor = () => {

if (tableName) {
// Wait for PK column to be fetched before showing results
await fetchPkColumn(tableName, targetTabId);
await fetchPkColumn(tableName, targetTabId, targetTab?.schema ?? undefined);
} else {
// No table, explicitly set pkColumn to null (read-only mode)
updateTab(targetTabId, { pkColumn: null });
Expand Down