fix: pass missing host fields to terminal WebSocket connection#15
Open
ZacharyZcR wants to merge 1 commit into
Open
fix: pass missing host fields to terminal WebSocket connection#15ZacharyZcR wants to merge 1 commit into
ZacharyZcR wants to merge 1 commit into
Conversation
…Username to terminal connection These fields were defined on SSHHost but omitted from the terminal hostConfig passthrough. Without jumpHosts the backend cannot route through jump servers; without forceKeyboardInteractive hosts that require keyboard-interactive auth fail silently; without overrideCredentialUsername shared credentials use the wrong username. Fixes Termix-SSH/Support#422 Fixes Termix-SSH/Support#638
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jumpHostswas never included in the terminal connection config, so the backend had no jump server routing info.forceKeyboardInteractivewas missing, causing hosts that require this auth method to fail silently.overrideCredentialUsernamewas not passed through, so shared credentials always used the credential's username instead of the host-specific override.Files Changed
app/tabs/sessions/terminal/NativeWebSocketManager.tsjumpHosts,forceKeyboardInteractive,overrideCredentialUsernametoTerminalHostConfigapp/tabs/sessions/terminal/Terminal.tsxTerminalProps.hostConfigapp/tabs/sessions/Sessions.tsxsession.hostTest plan
forceKeyboardInteractiveenabled → connect → should use keyboard-interactive authnpx tsc --noEmitshows no new type errorsFixes Termix-SSH/Support#422
Fixes Termix-SSH/Support#638