Skip to content

fix: validate product report spec links#249

Merged
Terry-Mao merged 2 commits into
mainfrom
spec/issue-239
Jun 8, 2026
Merged

fix: validate product report spec links#249
Terry-Mao merged 2 commits into
mainfrom
spec/issue-239

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Closes #239

Summary

  • 为 product change report 状态校验新增 spec 链接规范检查,拒绝外部 URL、裸路径、缺失文件和非 product.md / tech.md 目标。
  • 同步更新 product-change-report workflow prompt 和 skill 文案,要求从 docs/updates/ 使用相对 Markdown 链接引用 checked-in specs。
  • 增加产品报告测试覆盖合法 spec 链接和多类错误链接,防止错误 spec source reference 进入 ledger。

Validation

  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/aicodingflow-tests -p 'test_product_change_report.py'
  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/aicodingflow-tests
  • PYTHONPYCACHEPREFIX=/tmp/aicodingflow-pycache python3 -m py_compile .github/scripts/check_product_change_report_status.py
  • git diff --check

Notes

  • .agents/skills/product-change-report/SKILL.md 在当前沙箱只读,完整替换文件已写入 .codex-runtime/handoff/implementation-output/.agents/skills/product-change-report/SKILL.md 供外层 workflow 应用。
  • 本次变更包含 .github/workflows/product-change-report.yml,外层 workflow 需要 WORKFLOW_UPDATE_TOKEN 才能推送 workflow 文件变更。

@github-actions
github-actions Bot requested a review from Terry-Mao as a code owner June 8, 2026 09:08
@Terry-Mao Terry-Mao added the plan-approved Implementation plan has been approved label Jun 8, 2026
@github-actions github-actions Bot changed the title docs(spec): create issue 239 specs fix: validate product report spec links Jun 8, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未发现需要阻塞合并的问题。已按 spec context 核对新增 spec 链接校验、生成提示和测试覆盖;相关产品报告测试通过。

@Terry-Mao
Terry-Mao merged commit 4190d0f into main Jun 8, 2026
3 checks passed
@Terry-Mao
Terry-Mao deleted the spec/issue-239 branch June 8, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan-approved Implementation plan has been approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

product report 中 spec 链接地址不对

1 participant