fix: always show Sign In button in both light and dark modes#181
Merged
texture-fleet-agent[bot] merged 2 commits intomainfrom Apr 26, 2026
Merged
fix: always show Sign In button in both light and dark modes#181texture-fleet-agent[bot] merged 2 commits intomainfrom
texture-fleet-agent[bot] merged 2 commits intomainfrom
Conversation
- Remove showAuth gate — Sign In now renders immediately in both light and dark modes without waiting for Clerk isLoaded - Move Sign In above Dark/GitHub row in mobile drawer so it's visible without scrolling - Simplify auth conditional: isSignedIn ? UserMenu : SignIn
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sign In button was not visible in light mode on the mobile drawer. The root cause: button rendering was gated behind Clerk's
isLoadedstate (showAuth = mounted && isLoaded), and if Clerk was slow to initialize the button never appeared.Changes
showAuthgate entirely — Sign In now renders immediately regardless of Clerk loading stateisSignedIn ? UserMenu : SignIn— cleaner, always visibleBefore
Sign In button hidden in light mode until Clerk finishes loading (which may not happen quickly on mobile)
After
Sign In button always visible in both light and dark modes, prominently placed above utility buttons
Co-authored-by: Nicholas Brown nicholasalanbrown@gmail.com