Skip to content

Conversation

@bobtista
Copy link

Fix spelling errors in code comments.

@greptile-apps
Copy link

greptile-apps bot commented Jan 18, 2026

Greptile Summary

This PR corrects spelling errors across 90 C++ source files in the Generals/Code/GameEngine/Source directory. All changes are confined to code comments only - no actual code logic, function names, or variable names were modified.

Common corrections made:

  • definitonsdefinitions
  • extentionextension (18 instances in AIDock.cpp alone)
  • althoughtalthough
  • wierdweird
  • emtpyempty
  • poinerpointer
  • contructorconstructor
  • precendenceprecedence
  • indicitiveindicative

The PR maintains perfect symmetry with 211 insertions and 211 deletions, confirming pure line replacements. No copyright headers, code logic, or whitespace was altered.

Confidence Score: 5/5

  • This PR is safe to merge with zero risk - only comment spelling corrections
  • Score of 5 reflects that this is a documentation-only change affecting comments across 90 files. All modifications are spelling corrections with no impact on compiled code, runtime behavior, or build process. Perfect insertion/deletion symmetry confirms no logic changes.
  • No files require special attention - all changes are benign spelling corrections

Important Files Changed

Filename Overview
Generals/Code/GameEngine/Source/GameLogic/AI/AIDock.cpp Fixed 18 spelling errors: "extention" -> "extension"
Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp Fixed 13 spelling errors: althought->although, emtpy->empty, wierd->weird, poiner->pointer, contructor->constructor, indicitive->indicative, precendence->precedence
Generals/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp Fixed 7 spelling errors in comments
Generals/Code/GameEngine/Source/GameClient/GUI/GameWindowManager.cpp Fixed 7 spelling errors in comments
Generals/Code/GameEngine/Source/GameLogic/Object/Object.cpp Fixed 10 spelling errors in comments

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Files as 90 Source Files
    participant Comments as Code Comments
    participant Docs as Documentation Quality
    
    Dev->>Files: Identify spelling errors
    Files->>Comments: Scan comment text
    Comments-->>Dev: Return misspelled words
    Note over Comments: definitons, extention, althought,<br/>wierd, emtpy, poiner, etc.
    Dev->>Comments: Apply corrections
    Comments->>Comments: Replace misspellings
    Note over Comments: definitions, extension, although,<br/>weird, empty, pointer, etc.
    Comments->>Docs: Improve readability
    Docs-->>Dev: Enhanced documentation quality
Loading

@xezon xezon added the Documentation Is documentation or complementary resource label Jan 19, 2026
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@xezon
Copy link

xezon commented Jan 22, 2026

I do not understand the splitting of this change. The title claims one thing, but the actual changes files are in all sorts of unrelated folders that do correspond to what the title says.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (2)

  1. Generals/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp, line 2747 (link)

    syntax: Method renamed from setUninterruptable to setUninterruptible in AudioEventRTS.h but call site not updated - will cause compilation error.

  2. Core/GameEngine/Source/Common/Audio/GameAudio.cpp, line 438 (link)

    style: Comment still uses old spelling "uninterruptable" - should be updated to "uninterruptible" for consistency with the renamed API.

141 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Comment on lines 576 to 578
if (m_ww3dInited) {
W3DShaderManager::shutdown();
WW3D::Set_Device_Resolution(m_actualWinSize.x, m_actualWinSize.y, true);
W3DShaderManager::init();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Removed W3DShaderManager::shutdown() and W3DShaderManager::init() calls - this appears to be unrelated to spelling corrections and may cause shader management issues during resolution changes. Was this shader cleanup intentional or accidentally included in this spelling fix PR?

Prompt To Fix With AI
This is a comment left during a code review.
Path: Generals/Code/Tools/WorldBuilder/src/wbview3d.cpp
Line: 576:578

Comment:
**logic:** Removed `W3DShaderManager::shutdown()` and `W3DShaderManager::init()` calls - this appears to be unrelated to spelling corrections and may cause shader management issues during resolution changes. Was this shader cleanup intentional or accidentally included in this spelling fix PR?

How can I resolve this? If you propose a fix, please make it concise.

@bobtista bobtista force-pushed the fix/typos-generals-source branch from 7f6136c to 2551640 Compare January 22, 2026 21:29
if( commandSource == CMD_FROM_PLAYER && (!victim->testScriptStatusBit( OBJECT_STATUS_SCRIPT_TARGETABLE ) || r == ALLIES) )
{
//Unless the object has a map propertly that sets it to be targetable (and not allied), then give up.
//Unless the object has a map properly that sets it to be targetable (and not allied), then give up.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property

Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this change not also fix errors in Generals/Code/GameEngine/Inlcude like the Zero Hour change does?

@bobtista
Copy link
Author

Why does this change not also fix errors in Generals/Code/GameEngine/Inlcude like the Zero Hour change does?

I was trying to keep files changed below 100 - I added the changes that Zero Hour (2146) does here it was only 16 more files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Is documentation or complementary resource

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants