Improve Python deps checks and logging#116
Merged
Merged
Conversation
Use __CLASS__ for log tags instead of hardcoded 'tvremote' to standardize logging. Remove sudo from pip commands and add --no-cache-dir to pip invocations when checking/installing dependencies. Switch pip freeze to use shell_exec and include its output in logs for easier debugging of missing Python packages.
Improve Python deps checks and logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the dependency checking logic in the
tvremoteclass, focusing on more consistent logging and better pip command usage. The most important changes are:Dependency checking improvements:
dependancy_info()now use__CLASS__instead of the hardcoded'tvremote', ensuring correct class-based logging throughout the method.--no-cache-diroption and no longer usesudo, which can improve reliability and security when running these commands.