Skip to content

Improve Python deps checks and logging #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TiTidom-RC merged 2 commits into from
Jun 13, 2026
Merged

Improve Python deps checks and logging #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d9ec3
Improve Python deps checks and logging
TiTidom-RC Jun 13, 2026
37866bf
Merge pull request #115 from TiTidom-RC/dev
TiTidom-RC Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions core/class/tvremote.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,27 +77,27 @@ public static function dependancy_info() {
} else {
if (exec(system::getCmdSudo() . system::get('cmd_check') . '-Ec "python3\-requests|python3\-setuptools|python3\-dev|python3\-venv"') < 4) {
$return['state'] = 'nok';
log::add('tvremote', 'debug', '[Python-Dep] System packages missing (python3-requests, python3-setuptools, python3-dev, or python3-venv)');
log::add(__CLASS__, 'debug', '[Python-Dep] System packages missing (python3-requests, python3-setuptools, python3-dev, or python3-venv)');
} elseif (!file_exists(self::PYTHON3_PATH)) {
$return['state'] = 'nok';
log::add('tvremote', 'debug', '[Python-Dep] Python venv executable not found at: ' . self::PYTHON3_PATH);
log::add(__CLASS__, 'debug', '[Python-Dep] Python venv executable not found at: ' . self::PYTHON3_PATH);
} else {
$expectedCount = config::byKey('pythonDepNum', 'tvremote', 0, true);
$pythonDepString = config::byKey('pythonDepString', 'tvremote', '', true);

$cmd = system::getCmdSudo() . self::PYTHON3_PATH . ' -m pip freeze | grep -Ewci "' . $pythonDepString . '"';
$cmd = self::PYTHON3_PATH . ' -m pip --no-cache-dir freeze | grep -Ewci "' . $pythonDepString . '"';
$foundCount = exec($cmd);

if ($foundCount < $expectedCount) {
$return['state'] = 'nok';
log::add('tvremote', 'debug', '[Python-Dep] Missing Dependencies. Found: ' . $foundCount . ' / Expected: ' . $expectedCount);
log::add('tvremote', 'debug', '[Python-Dep] Regex used: ' . $pythonDepString);
log::add(__CLASS__, 'debug', '[Python-Dep] Missing Dependencies. Found: ' . $foundCount . ' / Expected: ' . $expectedCount);
log::add(__CLASS__, 'debug', '[Python-Dep] Regex used: ' . $pythonDepString);
// Log actual pip freeze content for debugging
$pipFreeze = shell_exec(system::getCmdSudo() . self::PYTHON3_PATH . ' -m pip freeze');
log::add('tvremote', 'debug', '[Python-Dep] Pip Freeze Output: ' . str_replace(PHP_EOL, ' | ', trim($pipFreeze)));
$pipFreeze = shell_exec(self::PYTHON3_PATH . ' -m pip --no-cache-dir freeze');
log::add(__CLASS__, 'debug', '[Python-Dep] Pip Freeze Output: ' . str_replace(PHP_EOL, ' | ', trim($pipFreeze)));
} else {
$return['state'] = 'ok';
log::add('tvremote', 'debug', '[Python-Dep] Dependencies installed. State : OK');
log::add(__CLASS__, 'debug', '[Python-Dep] Dependencies installed. State : OK');
}
}
}
Expand Down