Fix backwards compatibility tests on Windows.#595
Merged
teo-tsirpanis merged 5 commits intoDec 16, 2025
Conversation
teo-tsirpanis
deleted the
theodoretsirpanis/core-458-investigate-backwards-compatibility-failure-in-vector-search
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, Git checks out text files with CRLF line endings. This can cause problems when reading the backwards compatibility arrays, because TileDB supports only LF line endings at the moment in its line-delimited files.1
This PR fixes the test failures, by instructing Git to treat all test data as
binary, causing it to not modify line endings.Footnotes
In this case, the failures were caused by Optimize opening arrays — part 2 TileDB#5662, but CRLF support has been broken in other places before that. ↩