Skip to content

Fix backwards compatibility tests on Windows. #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teo-tsirpanis merged 5 commits into from
Dec 16, 2025
Merged

Fix backwards compatibility tests on Windows. #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
112285e
Treat backwards compatibility arrays as binary files.
teo-tsirpanis Dec 15, 2025
28f434a
Remove redundant README.
teo-tsirpanis Dec 15, 2025
73da6f0
Stop skipping tests on Windows.
teo-tsirpanis Dec 15, 2025
9428876
Fix wildcard.
teo-tsirpanis Dec 15, 2025
f79c8b2
Treat all test data as binary.
teo-tsirpanis Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
.git_archival.txt export-subst
*.qmd linguist-language=RMarkdown
backwards-compatibility-data/data/**/* binary
external/test-data/**/* binary
3 changes: 0 additions & 3 deletions backwards-compatibility-data/data/README.md
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions src/include/test/unit_backwards_compatibility.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,6 @@ TEST_CASE("test_query_old_indices", "[backwards_compatibility]") {
continue;
}

// Skip pre-0.16.0 versions on Windows due to blosc1/blosc2
// incompatibility. TileDB 2.30.0+ uses blosc2, but older test data was
// compressed with blosc1. blosc2 has a Windows-specific bug when
// decompressing blosc1 data.
#ifdef _WIN32
if (index_uri.find("0.16.0") == std::string::npos) {
continue;
}
#endif

auto read_group = tiledb::Group(ctx, index_uri, TILEDB_READ, cfg);
std::vector<float> expected_distances(query_indices.size(), 0.0);
if (index_uri.find("ivf_flat") != std::string::npos) {
Expand Down
Loading