Conversation
📝 WalkthroughWalkthroughThe README "Performance" section was updated to correct formatting on an existing benchmark entry and add comprehensive benchmark results for a MacBook Pro with Apple M4 Pro, including seven distinct performance metrics. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 30: The fenced benchmark code block in README.md is missing a language
tag causing MD040; update the fence opening from ``` to include a language such
as text (e.g., change the opening fence to ```text) so the block is annotated
and markdown linting passes, leaving the block contents and closing fence
unchanged.
- Line 28: Update the article before "MacBook Pro" in the README by replacing
"an MacBook Pro" with "a MacBook Pro" in the line containing the phrase "Tested
on an MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4:" so the sentence reads
"Tested on a MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4:".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| despawn 1000000 8.620 ms 8 ns/op | ||
| ``` | ||
|
|
||
| Tested on an MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4: |
There was a problem hiding this comment.
Fix article usage in the benchmark host description.
Line 28 should use “a MacBook Pro” instead of “an MacBook Pro”.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 28, Update the article before "MacBook Pro" in the README
by replacing "an MacBook Pro" with "a MacBook Pro" in the line containing the
phrase "Tested on an MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4:" so the
sentence reads "Tested on a MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4:".
|
|
||
| Tested on an MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Add a language to the fenced code block.
The new benchmark fence is missing a language tag (MD040). Please annotate it (for example, ```text) to satisfy markdown linting.
Proposed fix
-```
+```text
benchmark n total_ms ns/entity
----------------------------------------------------------------
spawn P+V 1000000 508.193 ms 508 ns/op
query iterate P+V 1000000 7.234 ms 7 ns/op
chunked + columnSlice P 1000000 2.950 ms 2 ns/op
getMut via query P 1000000 83.676 ms 83 ns/op
spawnPrefab (same prefab) 1000000 555.221 ms 555 ns/op
addComponent V (migrate) 1000000 709.130 ms 709 ns/op
removeComponent V (migrate) 1000000 571.632 ms 571 ns/op
despawn 1000000 85.006 ms 85 ns/op</details>
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.22.0)</summary>
[warning] 30-30: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against the current code and only fix it if needed.
In @README.md at line 30, The fenced benchmark code block in README.md is
missing a language tag causing MD040; update the fence opening from to include a language such as text (e.g., change the opening fence totext) so
the block is annotated and markdown linting passes, leaving the block contents
and closing fence unchanged.
</details>
<!-- fingerprinting:phantom:triton:hawk:d7f655a0-c605-4abe-be76-09f36c1c4653 -->
<!-- This is an auto-generated comment by CodeRabbit -->
|
These values are extremely high. Please make sure you ran the test in ReleaseFast and not the default debug optimization level. Something like: zig build -Doptimize=ReleaseFast performance -- 1000000 |
2 participants
Summary by CodeRabbit
Release Notes