Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ Prefabs for slime are essentially an id, mask and a set of components. There is

## Performance
Take these numbers with a grain of salt just like any performance tests. But for those of you who like numbers i guess here we go.
Tested on an i7 12700f.

Tested on an i7 12700f:

```
benchmark n total_ms ns/entity
Expand All @@ -23,3 +24,18 @@ addComponent V (migrate) 1000000 80.321 ms 80 ns/op
removeComponent V (migrate) 1000000 75.255 ms 75 ns/op
despawn 1000000 8.620 ms 8 ns/op
```

Tested on an MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix article usage in the benchmark host description.

Line 28 should use “a MacBook Pro” instead of “an MacBook Pro”.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` at line 28, Update the article before "MacBook Pro" in the README
by replacing "an MacBook Pro" with "a MacBook Pro" in the line containing the
phrase "Tested on an MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4:" so the
sentence reads "Tested on a MacBook Pro, Apple M4 Pro, 24GB, Tahoe 26.4:".


```
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add a language to the fenced code block.

The new benchmark fence is missing a language tag (MD040). Please annotate it (for example, ```text) to satisfy markdown linting.

Proposed fix
-```
+```text
 benchmark                         n      total_ms    ns/entity
 ----------------------------------------------------------------
 spawn P+V                      1000000    508.193 ms            508 ns/op
 query iterate P+V              1000000      7.234 ms              7 ns/op
 chunked + columnSlice P        1000000      2.950 ms              2 ns/op
 getMut via query P             1000000     83.676 ms             83 ns/op
 spawnPrefab (same prefab)      1000000    555.221 ms            555 ns/op
 addComponent V (migrate)       1000000    709.130 ms            709 ns/op
 removeComponent V (migrate)    1000000    571.632 ms            571 ns/op
 despawn                        1000000     85.006 ms             85 ns/op
</details>

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 markdownlint-cli2 (0.22.0)</summary>

[warning] 30-30: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against the current code and only fix it if needed.

In @README.md at line 30, The fenced benchmark code block in README.md is
missing a language tag causing MD040; update the fence opening from to include a language such as text (e.g., change the opening fence totext) so
the block is annotated and markdown linting passes, leaving the block contents
and closing fence unchanged.


</details>

<!-- fingerprinting:phantom:triton:hawk:d7f655a0-c605-4abe-be76-09f36c1c4653 -->

<!-- This is an auto-generated comment by CodeRabbit -->

benchmark n total_ms ns/entity
----------------------------------------------------------------
spawn P+V 1000000 508.193 ms 508 ns/op
query iterate P+V 1000000 7.234 ms 7 ns/op
chunked + columnSlice P 1000000 2.950 ms 2 ns/op
getMut via query P 1000000 83.676 ms 83 ns/op
spawnPrefab (same prefab) 1000000 555.221 ms 555 ns/op
addComponent V (migrate) 1000000 709.130 ms 709 ns/op
removeComponent V (migrate) 1000000 571.632 ms 571 ns/op
despawn 1000000 85.006 ms 85 ns/op
```