Skip to content

Comments

feat: adapt to v1#29

Closed
null8626 wants to merge 37 commits intoTop-gg-Community:mainfrom
null8626:v0
Closed

feat: adapt to v1#29
null8626 wants to merge 37 commits intoTop-gg-Community:mainfrom
null8626:v0

Conversation

@null8626
Copy link
Member

@null8626 null8626 commented Jun 16, 2025 •
edited
Loading

Closes #26
Closes #27
Closes #28

The following pull request does the following:

  • Adapts the Rust SDK to v0 and v1 by adding features such as reviews and removing many legacy features. (Note that the search feature in GET /bots which will be removed in v1 as per Veld, is also removed.)
  • Applies several minor refactors as per clippy.
  • Updates LICENSE copyright year.

As of v0, everything has been tested.

null8626 and others added 30 commits September 21, 2024 23:08
@null8626
refactor: simplify some lines of code
755bbe9
@null8626
fix: proper avatar URL coverage
41afa18
@null8626
doc: ALRIGHT WE GET IT ITS A (DISCORD) BOT
4ded956
@null8626
meta: update copyright year
7bff326
@null8626
feat: deprecate features no longer available in Top.gg API v0 [skip ci]
fb67642
@null8626
feat: add get_bots() again
b8dc6ba
@null8626
feat: add sort_by methods in GetBots
aee55e0
@null8626
feat: add v0
f38c5f0
@null8626
feat: add tests
cc310a7
@null8626
refactor: use iter instead of into_iter
00649aa
@null8626
refactor: ignore unreachable_patterns
43ec709
@null8626
doc: update docs for server count [skip ci]
33bfceb
@null8626
okay veld
b50a48c
@null8626
style: prettier
7ed5e65
@null8626
doc: tweak documentation for GetBots
4ce932c
@null8626
fix: remove get_user and fix several bugs
86cc496
@null8626
ci: uncomment tests [skip ci]
a05052f
@null8626
feat: name instead of username
cefca8d
@null8626
refactor: rework BotQuery
d119d73
@null8626
feat: add reviews
376cc56
@null8626
ci: remove test workflow
d2c5ee5
@null8626
feat: add page to get_voters
2af90fc
@null8626
doc: reword documentation
f4633a0
@null8626
doc: add NotFound description in has_voted
49d95f6
@null8626
doc: make this consistent
57bd4a7
@null8626
doc: shorten documentation
7c69ed0
@null8626
refactor: refactor from pedantic clippy
09ccf9f
@null8626
feat: remove url
48821be
@null8626
fix: fix: GET /bots/votes not working
f8888f0
@null8626
feat: fully adapt to v0
5569174
@null8626
Copy link
Member Author

null8626 commented Jun 17, 2025

Back to draft as Veld is currently working on widgets.

@null8626 null8626 marked this pull request as draft June 17, 2025 06:19
@null8626 null8626 changed the title feat: adapt to v0 feat: adapt to v1 Jun 17, 2025
@null8626
Copy link
Member Author

null8626 commented Jun 17, 2025

Veld recently said that v0 is deprecated, which means that the v0 pull requests will now be delayed to facilitate changes bound in v1, sorry!

@null8626 null8626 force-pushed the v0 branch 2 times, most recently from c9f1e16 to 84ccf95 Compare June 18, 2025 13:27
@null8626 null8626 force-pushed the v0 branch 3 times, most recently from 2bc23b1 to 1906dfc Compare June 24, 2025 10:06
@null8626 null8626 force-pushed the v0 branch 2 times, most recently from ef8e71a to 48a6902 Compare July 4, 2025 15:12
@null8626 null8626 marked this pull request as ready for review September 12, 2025 11:49
@null8626
Copy link
Member Author

null8626 commented Sep 12, 2025 •
edited
Loading

Hai everyone! At last we have a good news -- the SDK is now ready alongside v1! ❤️

@velddev
Copy link
Contributor

velddev commented Sep 13, 2025

By moving the files and editing them in the same PR, they are now un-reviewable. Please clean up and PR your changes in smaller batches

@null8626
Copy link
Member Author

null8626 commented Sep 13, 2025

Noted, thanks.

@null8626 null8626 mentioned this pull request Sep 13, 2025
Merged
@null8626
Copy link
Member Author

null8626 commented Sep 13, 2025 •
edited
Loading

This pull request will be split into 2 pull requests:

  1. The one that fixes/updates the v0 endpoints (feat: adapt to newer changes of v0 #30.)
  2. The one that adds v1 endpoints (TBA.)

@null8626 null8626 closed this Sep 13, 2025
@null8626 null8626 mentioned this pull request Sep 15, 2025
Closed
@null8626 null8626 mentioned this pull request Sep 23, 2025
Closed
@null8626 null8626 deleted the v0 branch February 21, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@null8626 @velddev