fix: astron error on cli

[nghaninn]

Summary

What is the background of this pull request?

Changes

• What are the changes made in this pull request?
• Change this and that, etc...

Issues

What are the related issues or stories?

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of transaction price display and gas price estimation for Astron and AstronTestnet networks, ensuring consistent behavior across supported networks.

[coderabbitai]

Walkthrough

Two network names, Astron and AstronTestnet, were added to the exclusion conditions within the canEstimateGasPrice and displayTransactionPrice functions in src/utils.ts. These functions now treat these networks similarly to several pre-existing networks by returning early or returning false as appropriate. Additionally, test assertions verifying the maxPriorityFeePerGas parameter as a digit string were removed from deployment tests for these networks.

Changes

Cohort / File(s)	Change Summary
Network Exclusion Logic Update src/utils.ts	Added Astron and AstronTestnet to exclusion checks in canEstimateGasPrice and displayTransactionPrice functions. No changes to function signatures.
Test Assertion Removal src/implementations/deploy/document-store/document-store-astron.test.ts, src/implementations/deploy/document-store/document-store-astrontestnet.test.ts	Removed assertions verifying maxPriorityFeePerGas as a digit string in deployment tests. No other test logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A hop and a skip, two networks appear,
Astron and its twin, now handled here.
Gas price and display, with care they’re addressed,
Tests trimmed and neat, assertions suppressed.
Rabbits rejoice—logic’s precise,
For every new network, we check it twice! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f39ecd and abbae90.

📒 Files selected for processing (2)

• src/implementations/deploy/document-store/document-store-astron.test.ts (0 hunks)
• src/implementations/deploy/document-store/document-store-astrontestnet.test.ts (0 hunks)

💤 Files with no reviewable changes (2)

• src/implementations/deploy/document-store/document-store-astron.test.ts
• src/implementations/deploy/document-store/document-store-astrontestnet.test.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Tests / Run Tests

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/cli-astron-transaction

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/utils.ts (1)

115-125: Update comment to reflect broader network coverage.

The implementation correctly adds Astron and AstronTestnet to the early return condition, maintaining consistency with the existing pattern. However, the comment on line 115 specifically mentions XDC but the condition now covers multiple network types with similar gas fee issues.

Consider updating the comment to be more generic:

-  // workaround for issue in XDC that unable to get gas fee after transaction
+  // workaround for networks that are unable to get gas fee after transaction

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6523407 and 0f39ecd.

📒 Files selected for processing (1)

• src/utils.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Tests / Run Tests

🔇 Additional comments (1)

src/utils.ts (1)

100-109: LGTM! Consistent pattern for network exclusion.

The addition of Astron and AstronTestnet to the gas price estimation exclusion list follows the established pattern for networks with gas estimation limitations. The implementation is clean and maintains consistency with existing XDC network handling.

[github-actions]

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀