Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

fix: astron error on cli #50

Merged
rongquan1 merged 2 commits into from
Jul 31, 2025
Merged

fix: astron error on cli #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f39ecd
fix: astron error on cli
nghaninn Jul 30, 2025
abbae90
fix: test error
nghaninn Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/implementations/deploy/document-store/document-store-astron.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ describe("document-store", () => {
expect(passedSigner.privateKey).toBe(`0x${deployParams.key}`);
expect(mockedDeploy.mock.calls[0][0]).toStrictEqual(deployParams.storeName);
expect(mockedDeploy.mock.calls[0][1]).toStrictEqual(deployParams.owner);
// price should be any length string of digits
expect(mockedDeploy.mock.calls[0][2].maxPriorityFeePerGas.toString()).toStrictEqual(expect.stringMatching(/\d+/));
expect(instance.contractAddress).toBe("contractAddress");
});

Expand Down
2 changes: 0 additions & 2 deletions src/implementations/deploy/document-store/document-store-astrontestnet.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ describe("document-store", () => {
expect(passedSigner.privateKey).toBe(`0x${deployParams.key}`);
expect(mockedDeploy.mock.calls[0][0]).toStrictEqual(deployParams.storeName);
expect(mockedDeploy.mock.calls[0][1]).toStrictEqual(deployParams.owner);
// price should be any length string of digits
expect(mockedDeploy.mock.calls[0][2].maxPriorityFeePerGas.toString()).toStrictEqual(expect.stringMatching(/\d+/));
expect(instance.contractAddress).toBe("contractAddress");
});

Expand Down
11 changes: 9 additions & 2 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ export const calculateMaxFee = (
};

export const canEstimateGasPrice = (network: string): boolean => {
if (network === NetworkCmdName.XDC || network === NetworkCmdName.XDCApothem) {
if (
network === NetworkCmdName.XDC ||
network === NetworkCmdName.XDCApothem ||
network === NetworkCmdName.Astron ||
network === NetworkCmdName.AstronTestnet
) {
return false;
}
return true;
Expand All @@ -112,7 +117,9 @@ export const displayTransactionPrice = async (
network === NetworkCmdName.XDC ||
network === NetworkCmdName.XDCApothem ||
network === NetworkCmdName.StabilityTestnet ||
network === NetworkCmdName.Stability
network === NetworkCmdName.Stability ||
network === NetworkCmdName.Astron ||
network === NetworkCmdName.AstronTestnet
) {
return;
}
Expand Down