Fix silent failures in whitelist add/remove operations#119
Merged
Conversation
Co-authored-by: Yashb404 <139128977+Yashb404@users.noreply.github.com>
Co-authored-by: Yashb404 <139128977+Yashb404@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on secure embed authorization implementation
Fix silent failures in whitelist add/remove operations
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whitelist modifications were silently ignoring all failures, hiding network errors and authorization issues from users while still triggering UI refetches.
Changes
resp.ok()before refetching whitelist dataconsole::error_1to surface HTTP errors and network failuresApplies to both
add_whitelist_itemandremove_whitelist_itemactions inclient/src/pages/view.rs.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.