Skip to content

Fix silent failures in whitelist add/remove operations #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yashb404 merged 3 commits into from
Feb 11, 2026
Merged

Fix silent failures in whitelist add/remove operations #119

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15b0a71
Initial plan
Copilot Feb 11, 2026
d870e3b
Improve error handling for whitelist add/remove operations
Copilot Feb 11, 2026
beca6bd
Use console::error_1 instead of console::log_1 for error messages
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions client/src/pages/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,22 @@ pub fn ViewPage() -> impl IntoView {
.json(&serde_json::json!({ "allowed_url": url }));

if let Ok(builder) = req {
let _ = builder.send().await;
whitelist_resource.refetch();
match builder.send().await {
Ok(resp) => {
if resp.ok() {
whitelist_resource.refetch();
} else {
web_sys::console::error_1(&JsValue::from_str(&format!(
"Failed to add URL to whitelist: HTTP {}", resp.status()
)));
}
}
Err(e) => {
web_sys::console::error_1(&JsValue::from_str(&format!(
"Failed to add URL to whitelist: {:?}", e
)));
}
}
}
}
});
Expand All @@ -211,8 +225,22 @@ pub fn ViewPage() -> impl IntoView {
.json(&serde_json::json!({ "allowed_url": url }));

if let Ok(builder) = req {
let _ = builder.send().await;
whitelist_resource.refetch();
match builder.send().await {
Ok(resp) => {
if resp.ok() {
whitelist_resource.refetch();
} else {
web_sys::console::error_1(&JsValue::from_str(&format!(
"Failed to remove URL from whitelist: HTTP {}", resp.status()
)));
}
}
Err(e) => {
web_sys::console::error_1(&JsValue::from_str(&format!(
"Failed to remove URL from whitelist: {:?}", e
)));
}
}
}
}
});
Expand Down