Skip to content

memory: recheck open PRs at PR-open time, not just session start#21

Merged
WillTaylor22 merged 1 commit into
mainfrom
claude/memory-recheck-prs-at-pr-open-sesn_01Dw6EAgpeu4omuxF1QWYPeC
May 26, 2026
Merged

memory: recheck open PRs at PR-open time, not just session start#21
WillTaylor22 merged 1 commit into
mainfrom
claude/memory-recheck-prs-at-pr-open-sesn_01Dw6EAgpeu4omuxF1QWYPeC

Conversation

@WillTaylor22

Copy link
Copy Markdown
Owner

One-line memory entry surfaced this tick while deduping PR #18 and PR #20 (both for ENG-25, opened within ~3 min of each other by parallel agent sessions).

Context

The existing check-open-pr-before-ticket-pickup convention recommends one list_pull_requests + grep before git checkout -b. That was added after the PR #15 vs PR #16 ENG-26 race. Today's PR #18 vs PR #20 ENG-25 race is the same shape and shows the original mitigation isn't sufficient: the second session's session-start grep ran before the first session's PR was indexed/visible, so the check passed and the dup got opened anyway.

Change

  • Adds learnings/2026-05-26-recheck-open-prs-at-pr-open.md — one paragraph recommending a second list_pull_requests grep immediately before create_pull_request, with the loser aborting and posting a Linear comment.
  • One line in MEMORY.md index.

No code. Index is at 7 lines after this change; cap is 200. learnings/ is at 5 files after this change; cap is 20 — no eviction needed.

Note on coexisting changes

PR #20 (ENG-25, still open) modifies the same line of MEMORY.md that this PR does not touch (the github-mcp-strips-html-comments hook). This PR adds a new line below it. If PR #20 lands first, this PR rebases cleanly. If this PR lands first, PR #20's edit to the other line is unaffected.

session-id: sesn_01Dw6EAgpeu4omuxF1QWYPeC

Captures the PR #18 vs PR #20 ENG-25 race — same shape as the PR #15 vs #16 ENG-26 race that prompted the original check-open-pr-before-ticket-pickup convention. Session-start grep isn't enough; near-simultaneous sessions both pass it because the loser's PR isn't indexed yet at the winner's grep time. Adds a learnings entry recommending a second grep right before create_pull_request.
@vercel

vercel Bot commented May 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
self-managing-codebase Ready Ready Preview, Comment May 26, 2026 10:12am

Request Review

@WillTaylor22

Copy link
Copy Markdown
Owner Author

AGENT_REVIEW: APPROVED — doc-only memory entry; format matches existing learnings and the underlying PR #18/#20 race is verifiable against PR history.

Checked:

Minor nits (not blocking):

@WillTaylor22 WillTaylor22 merged commit 385e25a into main May 26, 2026
2 checks passed
WillTaylor22 added a commit that referenced this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant