Fix url validation errors#11835
Merged
Merged
Conversation
4 tasks
d926d48 to
e810f59
Compare
…th a fragment to be invalid
…d instead of the first
… to and including the colon
noisysocks
approved these changes
Nov 16, 2018
|
|
||
| const fragment = getFragment( trimmedHref ); | ||
| if ( fragment && ! isValidFragment( trimmedHref ) ) { | ||
| if ( fragment && ! isValidFragment( fragment ) ) { |
e810f59 to
3a9d211
Compare
4 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When adding href validation in #11286 I made a few errors, which this PR addresses
isValidFragment(the entire href was being passed instead of just the fragment).getFragmentonly captured from the last occurrence of a hash, now it captures from the first.isValidProtocolconsidered a protocol with trailing forward slashes as valid. I realised this didn't match whatgetProtocolconsidered a protocol (characters up to and including the colon, e.g. 'http:'), so I've made it stricter.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: