Components: Restore default opacity to buttons#16769
Merged
Merged
Conversation
aduth
added
[Type] Bug
aduth
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta and
youknowriad
as code owners
aduth
changed the title
This was referenced Jul 26, 2019
jorgefilipecosta
approved these changes
Jul 26, 2019
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Worked as expected in my tests 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Partly) extracted: #16761
Related (reverts): #16581
Related (partially reverts): #16103
This pull request seeks to restore default dimmed opacity to buttons, removed as part of #16103. This can be seen for DropdownMenu buttons in #16581, and for the Undo/Redo buttons of a new post.
It tries to respect the intention of #16103 by effectively unsetting the default opacity for
isPrimaryandisDefault(the "WordPress-styled") button variants, thus not regressing the intention of that pull request.It's assumed that, since
.components-buttonstyling otherwise resets all browser-default appearance of a button, there should be some effect to indicate the disabled state of a button, as otherwise (as seen in the "Before" screenshot) they cannot be distinguished from non-disabled buttons.Testing Instructions:
Repeat testing instructions from #16103
Verify buttons for Undo/Redo for a new post appear as disabled