Scripts: Add WordPress folder to the list of ignores in configs#17296
Merged
Conversation
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
youknowriad
as code owners
gziolo
force-pushed
the
update/scripts-ignore
branch
from
16e4f20 to
0f28a37
Compare
gziolo
commented
Sep 2, 2019
gziolo
commented
Sep 2, 2019
gziolo
added
[Tool] WP Scripts
ntwb
approved these changes
Sep 2, 2019
5 tasks
ntwb
pushed a commit
that referenced
this pull request
Sep 3, 2019
ntwb
pushed a commit
that referenced
this pull request
Sep 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #17004 where
wp-scripts env installaddswordpressfolder with the local instance of WordPress.This PR adds this new
wordpressfolder to all recommended configs in@wordpress/scriptsto ensure that this folder is ignored and doesn't trigger any false alarms. This is quite similar to what happens in Gutenberg with the config overrides:gutenberg/.eslintignore
Line 9 in f198997
gutenberg/.stylelintignore
Line 1 in f198997
Testing
Basically all the following should work as before:
npm run lint-cssnpm run lint-jsnpm run lint-pkg-jsonnpm run test-e2enpm run test-unitI did some testing by adding files with failures to the
wordpressfolder.