Avoid using DOMRect constructor for Edge and IE#20103
Closed
ellatrix wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@aduth I'm guessing you prefer the polyfill? :) |
Member
|
@ellatrix I’ve no preference for it if it can be easily avoided to remove DOMRect. I’m mobile currently but can check later if it’s simple enough to use plain objects. I’d wonder what purpose DOMRect would otherwise serve, or were just not using those features? |
Member
|
I'm struggling to see what might have been the original purpose to use https://developer.mozilla.org/en-US/docs/Web/API/DOMRect I guess the only worry there would be is if we're passing around these |
Member
|
Polyfill alternative approach is at #20110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19979. Not sure if this is the solution we want, but it does get rid of calling DOMRect.
How has this been tested?
Screenshots
Types of changes
Checklist: