Compat: Add DOMRect polyfill#20110
Merged
Merged
Conversation
aduth
added
[Type] Bug
6 tasks
jorgefilipecosta
approved these changes
Feb 9, 2020
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
LGTM 👍 Fixes the problem in my tests.
ellatrix
approved these changes
Feb 10, 2020
This was referenced Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19979
Alternative to #20103
Related: #19823, https://core.trac.wordpress.org/ticket/49360
This pull request seeks to add a polyfill for DOMRect to resolve errors which can occur when using browsers which do not support this feature (Internet Explorer, Edge). It is modeled after the changes in #19823, and uses the same
polyfill-librarylibrary. The library version at the version inherited from core (3.26.0) did not include this at the time, and it was only made available later. The changes are pinned to the current version as of the time of writing (3.42.0). An upgrade to this dependency would be required for an equivalent core patch.Testing Instructions:
Repeat steps to reproduce from #19979, verifying no error.