[RNMobile] Add reusable block insertion test case#32506
Merged
fluiddot merged 24 commits intoJun 24, 2021
Conversation
We shouldn't update the state from the slot rendering because it's a different component, otherwise it fails with the following error: Warning: Cannot update a component (`BlockMobileToolbar`) while rendering a different component (`BlockSettingsFill`). To locate the bad setState() call inside `BlockSettingsFill`, follow the stack trace as described in https://fb.me/setstate-in-render
fluiddot
added
Mobile App - i.e. Android or iOS
…-tests # Conflicts: # packages/block-library/src/block/test/edit.native.js # test/native/__mocks__/styleMock.js # test/native/helpers.js
|
Size Change: -3.04 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
fluiddot
commented
Jun 23, 2021
| ) | ||
| ); | ||
|
|
||
| expect( reusableBlockRequest ).toBeDefined(); |
Contributor
Author
There was a problem hiding this comment.
I decided to remove this check because it's already covered when verifying the existence of the reusable block.
fluiddot
commented
Jun 23, 2021
| expect( reusableBlockRequest ).toBeDefined(); | ||
| expect( reusableBlock ).toBeDefined(); | ||
| expect( blockDeleted ).toBeDefined(); | ||
| expect( getEditorHtml() ).toBe( initialHtml ); |
Contributor
Author
There was a problem hiding this comment.
We're not making modifications to the content so this check is not really necessary.
fluiddot
commented
Jun 23, 2021
Comment on lines
+116
to
+121
| searchFormPlaceholder: { | ||
| color: 'gray', | ||
| }, | ||
| ripple: { | ||
| backgroundColor: 'white', | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
These styles are required to render the inserter menu.
fluiddot
commented
Jun 23, 2021
| } ); | ||
|
|
||
| export async function initializeEditor( { initialHtml } ) { | ||
| export async function initializeEditor( props ) { |
Contributor
Author
There was a problem hiding this comment.
This change allows us to pass any Editor prop on the initialization like the capabilities object.
dcalhoun
reviewed
Jun 23, 2021
Member
There was a problem hiding this comment.
The tests pass locally for me, however I noticed a few warning logs. Have you seen these as well? Can we address these or are they unrelated?
Test Warning Logs
console.warn
`wp.data.select( 'core/editor' ).getBlockSelectionEnd` is deprecated since version 5.3. Please use `wp.data.select( 'core/block-editor' ).getBlockSelectionEnd` instead.
75 |
76 | // eslint-disable-next-line no-console
> 77 | console.warn( message );
| ^
78 |
79 | logged[ message ] = true;
80 | }
at deprecated (packages/deprecated/src/index.js:77:10)
at packages/editor/src/store/selectors.js:1338:3
at selector (packages/data/src/factory.js:43:3)
at packages/data/src/redux-store/index.js:135:16
at getBlockSelectionEnd (packages/data/src/redux-store/index.js:280:27)
at mapSelectToProps (packages/edit-post/src/components/header/header-toolbar/index.native.js:128:28)
at mapSelect (packages/data/src/components/with-select/index.js:55:6)
console.warn
`wp.data.select( 'core/editor' ).getBlockRootClientId` is deprecated since version 5.3. Please use `wp.data.select( 'core/block-editor' ).getBlockRootClientId` instead.
75 |
76 | // eslint-disable-next-line no-console
> 77 | console.warn( message );
| ^
78 |
79 | logged[ message ] = true;
80 | }
at deprecated (packages/deprecated/src/index.js:77:10)
at packages/editor/src/store/selectors.js:1338:3
at selector (packages/data/src/factory.js:43:3)
at packages/data/src/redux-store/index.js:135:16
at getBlockRootClientId (packages/data/src/redux-store/index.js:280:27)
at mapSelectToProps (packages/edit-post/src/components/header/header-toolbar/index.native.js:128:6)
at mapSelect (packages/data/src/components/with-select/index.js:55:6)
console.warn
`wp.data.select( 'core/editor' ).hasInserterItems` is deprecated since version 5.3. Please use `wp.data.select( 'core/block-editor' ).hasInserterItems` instead.
75 |
76 | // eslint-disable-next-line no-console
> 77 | console.warn( message );
| ^
78 |
79 | logged[ message ] = true;
80 | }
at deprecated (packages/deprecated/src/index.js:77:10)
at packages/editor/src/store/selectors.js:1338:3
at selector (packages/data/src/factory.js:43:3)
at packages/data/src/redux-store/index.js:135:16
at hasInserterItems (packages/data/src/redux-store/index.js:280:27)
at mapSelectToProps (packages/edit-post/src/components/header/header-toolbar/index.native.js:127:5)
at mapSelect (packages/data/src/components/with-select/index.js:55:6)
Contributor
Author
Yeah, I noticed this too but it's also happening when running the app, probably began to happen after the RN |
Contributor
Author
I addressed this issue in this PR 🎊 . |
This was referenced Jun 24, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3654Description
Add the block insertion case for the reusable block.
This PR also introduces fixes for rendering the inserter menu in the tests and addresses the warning
Cannot update component while rendering a different componentdescribed in this issue.How has this been tested?
npm run native test block/test(in gutenberg) ornpm run core test block/test(in gutenberg-mobile)Screenshots
N/A
Types of changes
New integration test.
Checklist:
*.native.jsfiles for terms that need renaming or removal).