Try nested patterns previews with block editor setting#44784
Merged
ntsekouras merged 1 commit intoOct 12, 2022
Conversation
ntsekouras
added
the
[Feature] Inserter
|
Size Change: +53 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Contributor
|
I like this. I wonder what other "optimizations" we could do in BlockPreviews (like avoid rendering a lot of UI...) Curious what others think |
Contributor
|
I think this is the way to go. I closed out my PR in favor of this. |
Contributor
Author
@youknowriad do you think we can land this and create a follow up issue for further optimizations? I think it would take some time to identify such things and measure perf results from excluding them. |
ntsekouras
deleted the
update/dont-preparse-patterns-on-block-previews
branch
Member
|
Same, nice to see this land! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
An attempt to fix: #39732
Alternative to #42832 and #44773
Why?
In every block editor instance inside the
BlockListwe useusePreParsePatternsfor better performance to preparse the available patterns. This means we would need to parse them for every block preview that loads a new editor. This PR introduces a new block editor setting(__unstableIsPreviewMode) which is checked in theusePreParsePatternshook. So in the scenario of nested patterns, they will be lazy loaded/parsed.Testing Instructions