Skip to content

WP_Query: Prevent get_queried_object() from returning false in author queries#12069

Open
USERSATOSHI wants to merge 2 commits into
WordPress:trunkfrom
USERSATOSHI:fix/get-queried-object-return-false
Open

WP_Query: Prevent get_queried_object() from returning false in author queries#12069
USERSATOSHI wants to merge 2 commits into
WordPress:trunkfrom
USERSATOSHI:fix/get-queried-object-return-false

Conversation

@USERSATOSHI
Copy link
Copy Markdown

Prevents WP_Query::get_queried_object() from returning false in author queries. The documented return type is WP_Term|WP_Post_Type|WP_Post|WP_User|null, but get_userdata() can return false when passed a non-existent user ID or null.

Two scenarios caused false to leak out:

  1. $this->queried_object_id stays null (no author resolved) -> get_userdata( null ) -> false
  2. A non-existent author ID is set (e.g. ?author=999999) -> get_userdata( 999999 ) -> false

The fix guards both the get_userdata() call and its return value so $this->queried_object stays null in these edge cases, matching the documented return type.

Trac ticket: https://core.trac.wordpress.org/ticket/65400

Use of AI Tools

AI assistance: Yes
Tool(s): opencode (claude)
Model(s): deepseek-v4-flash-free
Used for: Tests.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@USERSATOSHI USERSATOSHI marked this pull request as ready for review June 3, 2026 14:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props tusharbharti.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant