WP_Query: Prevent get_queried_object() from returning false in author queries#12069
WP_Query: Prevent get_queried_object() from returning false in author queries#12069USERSATOSHI wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Prevents
WP_Query::get_queried_object()from returningfalsein author queries. The documented return type isWP_Term|WP_Post_Type|WP_Post|WP_User|null, butget_userdata()can returnfalsewhen passed a non-existent user ID ornull.Two scenarios caused
falseto leak out:$this->queried_object_idstaysnull(no author resolved) ->get_userdata( null )->false?author=999999) ->get_userdata( 999999 )->falseThe fix guards both the
get_userdata()call and its return value so$this->queried_objectstaysnullin these edge cases, matching the documented return type.Trac ticket: https://core.trac.wordpress.org/ticket/65400
Use of AI Tools
AI assistance: Yes
Tool(s): opencode (claude)
Model(s): deepseek-v4-flash-free
Used for: Tests.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.