Skip to content

WP_Query: Prevent get_queried_object() from returning false in author queries #12069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
USERSATOSHI wants to merge 2 commits into
base: trunk
Choose a base branch
from
+41 −1
Open

WP_Query: Prevent get_queried_object() from returning false in author queries #12069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
772491d
fix: Prevent get_queried_object() from returning false in author queries
USERSATOSHI Jun 3, 2026
dfaa521
test: fix the non existent test case
USERSATOSHI Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/wp-includes/class-wp-query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4047,7 +4047,13 @@ public function get_queried_object() {
}
}

$this->queried_object = get_userdata( $this->queried_object_id );
if ( $this->queried_object_id ) {
$user = get_userdata( $this->queried_object_id );

if ( $user ) {
$this->queried_object = $user;
}
}
}

return $this->queried_object;
Expand Down
34 changes: 34 additions & 0 deletions tests/phpunit/tests/query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,40 @@ public function test_get_queried_object_should_work_for_author_name_before_get_p
$this->assertSame( get_queried_object_id(), $user_id );
}

/**
* @ticket 65400
*/
public function test_get_queried_object_should_return_null_when_author_id_is_non_existent() {
add_action(
'parse_query',
static function ( $query ) {
$query->is_author = true;
$query->set( 'author', 999999 );
}
);

$this->go_to( home_url( '/' ) );

$this->assertNull( get_queried_object() );
}

/**
* @ticket 65400
*/
public function test_get_queried_object_should_return_null_when_author_is_unset() {
// Trigger is_author without a valid author query var.
add_action(
'parse_query',
static function ( $query ) {
$query->is_author = true;
}
);

$this->go_to( home_url( '/' ) );

$this->assertNull( get_queried_object() );
}

/**
* Tests that the `posts_clauses` filter receives an array of clauses
* with the other `posts_*` filters applied, e.g. `posts_join_paged`.
Expand Down
Loading