Default VCS Python DUTs to no_save#87
Conversation
|
@Martinnn674 In your patch, the flag is only used when I suggest: def __init__(self, *args, **kwargs):
{% if __SIMULATOR__ == "vcs" %}
# For VCS we need this workaround. See issue #86
if not args or '-no_save' not in args:
args = args if args else () + ('-no_save',)
{% endif %} |
|
Good point. I kept it empty only to avoid changing behavior for callers who already pass explicit VCS args, but I agree that if picker does not support VCS save/restore here, adding Small note tho I think the suggested assignment would leave non empty if "-no_save" not in args:
args = args + ("-no_save",)That should preserve caller provided args and still make the workaround apply consistently. |
837dab4 to
d8cb185
Compare
|
Because #88 successfully launched VCS by disabling ASLR without using the Of course, we still appreciate your efforts in submitting the PR. |
Summary
-no_savewhen callers do not provide explicit simulator argsargsis emptyFixes #86.
Verification
NO_BUILD_XSPCOMM=1 cmake . -Bbuild -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_PARALLEL=2NO_BUILD_XSPCOMM=1 cmake --build build --target test_codegen_python_vcs_defaults -j2ctest --test-dir build -R test_codegen_python_vcs_defaults --output-on-failure