fix: disable ASLR when loading VCS simulator library#88
Merged
Conversation
Author
|
This issue is alternatively solved by #87 |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a VCS-specific workaround to disable ASLR during DUT initialization to prevent VCS from relaunching the process (and failing when argv is malformed).
Changes:
- Includes
<sys/personality.h>for access topersonality()/ADDR_NO_RANDOMIZE. - Disables ASLR at startup when
USE_VCSis defined, with logging and a warning on failure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixed variable might be undefined causing warning
Contributor
|
LGTM and test passed on VCS 2024. It will be merged after CI passes. |
Makiras
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As described in #86, VCS will launch a new instance of python after disabling ASLR. Because the argv to that
execvcall is malformed, this interrupts the original process and drops the user in a clean shell.To avoid this, we disable ASLR before VCS initializes and thus prevent the undesired behavior.
Fixes #86
Type of change
How Has This Been Tested?
Tested with VCS 2025 on Rocky 9.5 while using
LD_PRELOAD.